-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backdrop admin suggests this module's behaviour is wrong #7
Comments
I'm not maintaining this module, so I'm only guessing, that as a start the module was ported without adapting all things the Backdrop way. In this case, ideally it will be improved, e.g. allowing to use it without the Libraries module. In my opinion, it would be the best to open one issue per request. For instance open one issue called something like "Remove dependency of the Libraries module". From your report, it's not clear if there are other issues. Maybe you can ask the admin person who gave advice to you. |
@auxiliaryjoel although this module still uses the separate Libraries module for linking the necessary jQuery cycle script, it will still work for you. I have used it on a number of sites and as a check have just installed it successfully on a new test site. Yes, ideally it would be modified and a new release produced that follows the current Backdrop practice of including the jQuery script within the module. If, as suggested by @olafgrabienski, you would kindly report separately on your difficulty with the installation instructions, I (who ported this module from Drupal) will gladly see what help I can offer. |
OK no worries I will raise the "Remove dependency of the Libraries module" issue as you've suggested. Thanks @olafgrabienski |
Ok no problems @Graham-72 I'll create an issue specifying the issue I had |
This is now fixed in release 1.x-3.3.0 which removes dependency on Libraries module. |
I asked advice from Backdrop CMS admin about trouble I was having installing this module.
After reviewing it, they suggested that I raise an issue because there were problems with the instructions.
They also said the recommendation of using the Libraries module should never be necessary.
Backdrop admin felt this module was trying to do things "the Drupal way" instead of improving for Backdrop.
The text was updated successfully, but these errors were encountered: