Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Join as maintainer? #1

Closed
herbdool opened this issue May 3, 2023 · 10 comments
Closed

Join as maintainer? #1

herbdool opened this issue May 3, 2023 · 10 comments

Comments

@herbdool
Copy link
Contributor

herbdool commented May 3, 2023

@docwilmot do you mind if I join as maintainer? I'd like to get the basics working here.

@docwilmot
Copy link
Member

No sir, dont mind at all.

FYI I ported this in the impression that it could extend the core forward revisions we put in years ago then really ignored since. But I didnt feel that Workflow really meshes well with the forwrd revisions concepts much. Would be happy to hear your opinion there.

@herbdool
Copy link
Contributor Author

herbdool commented May 3, 2023

I guess I'd have to understand "forward revisions" before doing more work on this module. Do the two approaches clash?

@docwilmot
Copy link
Member

Do the two approaches clash?

Not really and perhaps I didnt try hard enough.

I guess I'd have to understand "forward revisions" before doing more work on this module

D7 could create multiple revisions of a node, but the current revision, the one seen by any user if the node is published, is always the latest created revision. Revisions are always "behind" or "before" the public facing node. So if anyone created a new revision, thats what the public sees automatically.

Forward revisions allows you to create "revisions" that are "forward" (not behind) the currently publicly visible one. So "forward revisions" allow you to have real drafts: you can have your editors, approvers, writing revisions by the dozen and yet the "story" visible on the site stays the same, until someone approves it to be the public facing version. Then "revise" it a dozen times again until youre happy and only then publish the latest version again.

Workflow, AFAICT, allows you to move a node between various "draft states" until someone publishes it.

It would be nice, if we could integrate the two concepts, so that even after it is published in Workflow, there is a UI to send it back to the draft states and have it sent around for approvals etc, until someone updates the current revision, and all new edits go live.

@stpaultim
Copy link
Member

@herbdool To refresh your memory.

We added some cool APIs.
backdrop/backdrop-issues#4354

But, we never finished the UI to expose them.
backdrop/backdrop-issues#4355

@herbdool
Copy link
Contributor Author

herbdool commented May 3, 2023

Thanks @docwilmot and @stpaultim for the info. I understand it a bit better now.

@herbdool
Copy link
Contributor Author

herbdool commented May 5, 2023

Now I'm not so sure about this module. To be useful it would need to store workflows, states and transitions in CMI. That is possible but complicates things. Plus I can't figure out why someone would need to be able to add fields to a workflow. Maybe someone has an idea. I've got the basics working but I'm not sure if I want to spend too much time on it. After looking more at workbench_moderation it actually seems to be simpler to port (though it depends on drafty).

@docwilmot
Copy link
Member

I think WBM seems to also be able to use the new revisions APIs as well.

@yorkshire-pudding
Copy link

I can think of use cases for adding fields to a workflow. Where the workflow is being used to handle a business process, then there may be additional information such as dates, people, references, events (perhaps you need a meeting to sign it off?).

I'm interested in this module, so would be happy to test if and when you get to that stage.

@herbdool
Copy link
Contributor Author

herbdool commented May 5, 2023

@yorkshire-pudding it's already kinda working, but I don't intend to do anything more to it or maintain it. Not sure if @docwilmot will.

@docwilmot workbench_moderation is looking pretty promising. I've got it working locally mostly. Much simpler and I think it'll be easier to convert to CMI.

@herbdool
Copy link
Contributor Author

herbdool commented May 6, 2023

Here we go: https://github.com/backdrop-contrib/content_moderation. It's mostly working. I renamed workbench_moderation to content_moderation because it doesn't rely on workbench, which could be ported separately.

@herbdool herbdool closed this as completed May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants