You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
so & should be replaced with .custom-icon-github and #{$insert} by before (as it is the defautl value)
Then the @extend %<%= cssClass%>; part should be called as $extend is true by default
which should result in the following logic :
.custom-icon-github should extend %cssClass (which in this case resolve to %custom-icon
therefore we shoudl not end-up with a .custom-icon:before selector but a .custom-icon-github:before selector since %custom-icon is (again if I understood how extends works right) resolved to .custom-icon-github:before (see http://sass-lang.com/documentation/file.SASS_REFERENCE.html#placeholders)
The text was updated successfully, but these errors were encountered:
Hello,
I'm having the same issue as #33. Unless I'm mistaken (which is possible), the following code :
should not result in the following (extracted from your test files) :
but rather :
Let me explain my thinking :
The "&:#{$insert}" part replaces & with whatever selector is used right before, based on your test files this is an example :
so & should be replaced with .custom-icon-github and #{$insert} by before (as it is the defautl value)
Then the @extend %<%= cssClass%>; part should be called as $extend is true by default
which should result in the following logic :
.custom-icon-github should extend %cssClass (which in this case resolve to %custom-icon
therefore we shoudl not end-up with a .custom-icon:before selector but a .custom-icon-github:before selector since %custom-icon is (again if I understood how extends works right) resolved to .custom-icon-github:before (see http://sass-lang.com/documentation/file.SASS_REFERENCE.html#placeholders)
The text was updated successfully, but these errors were encountered: