Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sentence for css code #56

Closed
demid3 opened this issue Dec 28, 2017 · 1 comment
Closed

Sentence for css code #56

demid3 opened this issue Dec 28, 2017 · 1 comment

Comments

@demid3
Copy link

demid3 commented Dec 28, 2017

Hi, I suggest changing the style templates, this will simplify the entries in the classes
in these templates: _icons.css, _icons.less, _icons.scss, _icons.styl
In the template, this entry:
.icon:before {...}
it is better to write like this
[class^="icon-"], [class*=" icon-"], [data-icon]:before {...}
[data-icon]:before { content: attr(data-icon) !important; }
instead of such a record <i class="icon icon-name"></i> it suffices to write so <i class="icon-name"></i> and as the data attribute <i data-icon="&#xe001"></i>.

@backflip
Copy link
Owner

@AlexanderPilipenko, thanks for your input! However, this very much depends on the CSS "architecture" you are relying on. Since approaches like BEM are very widespread and would roughly correspond to what we are doing here, I think we can keep the template as it is. You can always overwrite it anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants