Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backstage Upgrade Helper should provide a Git patch #11642

Closed
sonytricoire opened this issue May 21, 2022 · 8 comments
Closed

Backstage Upgrade Helper should provide a Git patch #11642

sonytricoire opened this issue May 21, 2022 · 8 comments
Labels
enhancement New feature or request help wanted Help/Contributions wanted from community members

Comments

@sonytricoire
Copy link

Feature Suggestion

Backstage Upgrade Helper could provide a git patch file for a one step migration using git apply

@sonytricoire sonytricoire added the enhancement New feature or request label May 21, 2022
@Rugvip
Copy link
Member

Rugvip commented May 23, 2022

Yep makes sense to have that easily available! I think with this in place it would be even better if we could avoid having the @backstage/* dependency bumps be part of the diff too.

Is this something you would like to contribute?

@Rugvip Rugvip added the help wanted Help/Contributions wanted from community members label May 23, 2022
@VladMasarik
Copy link
Contributor

VladMasarik commented Jun 7, 2022

@Rugvip Hi, I would like to contribute on this part, unless someone is already working on it.

Did I understand it correctly that one part would be to have some way of accessing the raw diff, and the second part would be to improve the diff?

My naive idea for the first one would be to just have a link right next to the "Show me how to upgrade!" button that would open a new tab with the RAW Github diff file. Would that fit our use case? For me that would be enough, although I would prefer to just directly opening up a download prompt for the diff file.

Can you expand on the second part though?

I think with this in place it would be even better if we could avoid having the @backstage/* dependency bumps be part of the diff too.

Do you mean removing code from the diff, which is meant for @backstage/* dependencies, and not for the project?

@VladMasarik
Copy link
Contributor

@sonytricoire @Rugvip What do you think of the above linked PR? It is not covering the "second requirement" from Rugvip yet though, and I still have to add docs to the backstage. I will do it once we merge in the previous PR.

@sonytricoire
Copy link
Author

Yep makes sense to have that easily available! I think with this in place it would be even better if we could avoid having the @backstage/* dependency bumps be part of the diff too.

Is this something you would like to contribute?

Hi !
Sorry but I won't have time to contribute myself.
Hopefully @VladMasarik can 👍

@VladMasarik your proposal seems ok to me (from a user perspective, I did not check technically), but I would add a short comment to explain "how to apply".

@Rugvip
Copy link
Member

Rugvip commented Jun 13, 2022

@VladMasarik yep I think that should solve it, thank you! 👍

The second requirement seems decoupled enough and can be treated as a completely separate improvement

@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Aug 12, 2022
@jhaals jhaals removed the stale label Aug 15, 2022
@benjdlambert
Copy link
Member

@VladMasarik I think that @vinzscam got back to you in the other ticket and is awaiting your reply 🙏

@vinzscam
Copy link
Member

Closed by backstage/upgrade-helper#8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Help/Contributions wanted from community members
Projects
None yet
Development

No branches or pull requests

6 participants