Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup CODEOWNERS for new plugins #139

Closed
stefanalund opened this issue Mar 2, 2020 · 2 comments · Fixed by #340
Closed

Setup CODEOWNERS for new plugins #139

stefanalund opened this issue Mar 2, 2020 · 2 comments · Fixed by #340
Assignees
Labels
cli CLI tool for plugins and apps repo Managing this repo

Comments

@stefanalund
Copy link
Contributor

Configure CODEOWNERS and define how external (non-Spotify team) can add parts of the repo.

@stefanalund stefanalund added the repo Managing this repo label Mar 2, 2020
@marcuseide
Copy link
Collaborator

We already have a CODEOWNERS file today, but additions to it should be part of the cli

@stefanalund stefanalund added the cli CLI tool for plugins and apps label Mar 6, 2020
@stefanalund stefanalund changed the title CODEOWNERS Setup CODEOWNERS for new plugins Mar 6, 2020
@Rugvip
Copy link
Member

Rugvip commented Mar 17, 2020

Should probably add a question about ownership in the create-plugin command. Default to not having any owner, but if one is specified we find the CODEOWNER file and add an entry. Probably expect the CODEOWNER file to exist

@Rugvip Rugvip added this to To do in Mandelbrot Mammoth Mar 17, 2020
@freben freben moved this from To do to In progress in Mandelbrot Mammoth Mar 19, 2020
@freben freben self-assigned this Mar 19, 2020
Mandelbrot Mammoth automation moved this from In progress to Done Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli CLI tool for plugins and apps repo Managing this repo
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants