Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃殌 Feature: Search autocomplete #16451

Open
2 tasks done
drodil opened this issue Feb 20, 2023 · 18 comments
Open
2 tasks done

馃殌 Feature: Search autocomplete #16451

drodil opened this issue Feb 20, 2023 · 18 comments
Labels
area:discoverability Related to the Discoverability Project Area enhancement New feature or request search Things related to Search

Comments

@drodil
Copy link
Contributor

drodil commented Feb 20, 2023

馃敄 Feature description

The search could suggest searching words using autocomplete. For example, ElasticSearch supports autocomplete to be returned in the response: https://www.elastic.co/guide/en/elasticsearch/reference/current/search-suggesters.html

馃帳 Context

For better user experience, the search could propose the search words for the user

鉁岋笍 Possible Implementation

Use MUI autocomplete for search input

馃憖 Have you spent some time to check if this feature request has been raised before?

  • I checked and didn't find similar issue

馃彚 Have you read the Code of Conduct?

Are you willing to submit PR?

None

@drodil drodil added the enhancement New feature or request label Feb 20, 2023
@github-actions github-actions bot added the search Things related to Search label Feb 20, 2023
@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Apr 21, 2023
@drodil
Copy link
Contributor Author

drodil commented Apr 21, 2023

Not stale, waiting for comments

@github-actions github-actions bot removed the stale label Apr 21, 2023
@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jun 20, 2023
@drodil
Copy link
Contributor Author

drodil commented Jun 20, 2023

Not stale, waiting for comments

@github-actions github-actions bot removed the stale label Jun 20, 2023
@efenner-cambia
Copy link
Contributor

It sounds great to me!

@Rugvip Rugvip added the area:discoverability Related to the Discoverability Project Area label Jun 22, 2023
@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Aug 21, 2023
@drodil
Copy link
Contributor Author

drodil commented Aug 22, 2023

Not stale, gathering interest

@github-actions github-actions bot removed the stale label Aug 22, 2023
@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Oct 21, 2023
@camilaibs
Copy link
Contributor

Thanks for opening the issue @drodil 馃檶馃徎 !
Let's ping @backstage/discoverability-maintainers for hearing their thoughts 馃檪

@github-actions github-actions bot removed the stale label Oct 23, 2023
@emmaindal
Copy link
Member

Hello @drodil thanks for opening this issue. Just for my own understanding. This feature request is to add auto complete support on the search engines side? The reason why I ask is because we have this AutoComplete component available but if I understand it correctly this is so that this auto complete component can be used with suggested terms?

@drodil
Copy link
Contributor Author

drodil commented Nov 7, 2023

So idea is to utilize the AutoComplete component for search and provide the suggested terms from the search engine as part of the SearchAPI response. Elastic/OpenSearch supports this out-of-the-box but for other search backends it should probably render nothing or figure a way to do this.

@emmaindal
Copy link
Member

So idea is to utilize the AutoComplete component for search and provide the suggested terms from the search engine as part of the SearchAPI response.

This makes sense to me. One thing that I'm not 100% sure about is if this has to be returned on the same response from the query endpoint, or if we want to introduce another endpoint responsible for only getting search suggestors. Have you been thinking about that anything when writing up the feature request?

Some (but not limited to) work that I see needs to happen as part of this is:

  1. Implement support for search suggestors on the search engine modules that supports this:
    • lunr (not a separate module but including here anyways)
    • search-backend-module-elasticsearch
    • search-backend-module-pg
  2. Support returning search suggestors from search backend
    a) by extending the query endpoint (and the resultset interface)
    b) introducing a new endpoint only responsible for returning the suggested terms
  3. depending on which path to take in 2, potentially extend the SearchApi interface with another method that can be implemented for getting search suggestions
  4. Potentially update the SearchAutocomplete component that already exist to get options from the search api instead of passing through as prop

Is this aligned with your thinking? Have I missed anything thats on top of your mind? We might want to discuss 2 and 3 before starting with 1, so that we are aligned on the approach and then we could split 1 into different engine specific issues to separate the work as long as the approach is settled on. From our side, this is not something that is on our near term roadmap, but if its something you want to come up with a proposal for I'm happy to support with feedback.

@drodil
Copy link
Contributor Author

drodil commented Nov 7, 2023

Sounds good. Maybe it requires a new endpoint for suggestions, I haven't really thought it through.

Splitting this into multiple issues makes a lot of sense as they can be worked on independently.

Copy link
Contributor

github-actions bot commented Jan 6, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jan 6, 2024
@emmaindal emmaindal removed the stale label Jan 8, 2024
Copy link
Contributor

github-actions bot commented Mar 8, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Mar 8, 2024
@drodil
Copy link
Contributor Author

drodil commented Mar 8, 2024

Not stale

@github-actions github-actions bot removed the stale label Mar 8, 2024
Copy link
Contributor

github-actions bot commented May 7, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label May 7, 2024
@drodil
Copy link
Contributor Author

drodil commented May 7, 2024

Still not stale 馃槃

@github-actions github-actions bot removed the stale label May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:discoverability Related to the Discoverability Project Area enhancement New feature or request search Things related to Search
Projects
None yet
Development

No branches or pull requests

6 participants
@drodil @Rugvip @camilaibs @emmaindal @efenner-cambia and others