Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃殌 Feature: Gated Scaffolder Workflows #16622

Open
2 tasks done
taras opened this issue Feb 27, 2023 · 18 comments
Open
2 tasks done

馃殌 Feature: Gated Scaffolder Workflows #16622

taras opened this issue Feb 27, 2023 · 18 comments
Labels
area:scaffolder Everything and all things related to the scaffolder project area enhancement New feature or request

Comments

@taras
Copy link
Member

taras commented Feb 27, 2023

馃敄 Feature description

We need a way to created Scaffolder workflows that includes actions that may span days.

There are a bunch of use cases that need this, for example:

  1. Wait for pull request to be merged - when a scaffolder workflow creates a pull request, we might want to wait for the pull request to be merged before continuing. Since merging pull requests requires human intervention, it may take days if not weeks for that action to complete.
  2. Wait for another user to provide additional input - when creating workflows that require approval from someone within the organization, we might need to wait for the user to press a button before the workflow continues.
  3. Wait for a resource to be created - when creating services, you might want to wait until a resource like a database is created before proceeding.

There is no way to do this currently.

馃帳 Context

At the last Adoption SIG, I demoed using the Embedded Scaffolder Workflow to onboard an entity to use TechDocs by creating a pull request with everything necessary to onboard the entity. This demo is missing a few details that are required to create a complete user experience.

We need to handle the following states,

  1. The workflow ran and created a pull request that needs to be merged. We need to show to the user that the PR is waiting.
  2. After the PR is merged, but before the YAML document is ingested, we need to show to the user that onboarding is pending ingestion.

Handing these states consistently is best handled by the framework because there are many ways to mess this up. The Gated Scaffolder Workflows will make handling these use cases very easy.

鉁岋笍 Possible Implementation

We need to create an RFC to flash out how this will work.

馃憖 Have you spent some time to check if this feature request has been raised before?

  • I checked and didn't find similar issue

馃彚 Have you read the Code of Conduct?

Are you willing to submit PR?

Yes I am willing to submit a PR!

@taras taras added the enhancement New feature or request label Feb 27, 2023
@github-actions github-actions bot added the area:scaffolder Everything and all things related to the scaffolder project area label Feb 27, 2023
@bforbis
Copy link
Contributor

bforbis commented Mar 31, 2023

Curious how this might relate to the Prefect workflow in the Box demo during this community session?
https://youtu.be/apCDT3_DmFk?t=669

@stephenmuss
Copy link

Is there any movement on this at all? Such as an RFC. I'd be interested to see this.

@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jun 21, 2023
@efenner-cambia
Copy link
Contributor

Any movement on this? I would also like to see this and it looks like the other issue that was linked above got auto-closed

@github-actions github-actions bot removed the stale label Jun 21, 2023
@taras
Copy link
Member Author

taras commented Jun 21, 2023

We're about to ship a project using the Embedded Scaffolder plugin. I'm hoping we'll have the opportunity to work on this next because it'll help to provide status on previous executions of scaffolder.

@sharadpattanshetti
Copy link
Contributor

We're about to ship a project using the Embedded Scaffolder plugin. I'm hoping we'll have the opportunity to work on this next because it'll help to provide status on previous executions of scaffolder.

Any example available on how this can be used in the templates?

@deeparavirdc
Copy link

deeparavirdc commented Aug 29, 2023

+1 @taras Is there some documentation or example on how to enable this in backstage and use it with templates ?

@npalm
Copy link

npalm commented Sep 14, 2023

Looking forward to gated support!

Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Nov 13, 2023
@efenner-cambia
Copy link
Contributor

@taras Any update?

@github-actions github-actions bot removed the stale label Nov 13, 2023
@Alok650
Copy link

Alok650 commented Dec 5, 2023

Following! This would be a very useful feature.

@benjdlambert
Copy link
Member

benjdlambert commented Dec 8, 2023

Related #21299

Copy link
Contributor

github-actions bot commented Feb 6, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Feb 6, 2024
@knksmith57
Copy link
Contributor

Bump to keep this alive 馃檹

Copy link
Contributor

github-actions bot commented Apr 6, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Apr 6, 2024
@ghost
Copy link

ghost commented Apr 8, 2024

Keep this alive!

@github-actions github-actions bot removed the stale label Apr 8, 2024
@ghost
Copy link

ghost commented Apr 8, 2024

@taras do you have any updates ?

@taras
Copy link
Member Author

taras commented Apr 8, 2024

@fvmiranda Not really; the client that needed this has other priorities now. We have a few ideas on how to build it, but we need bandwidth to do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:scaffolder Everything and all things related to the scaffolder project area enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

10 participants