Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃殌 Feature: Add support for GitHub Environment Tag Patterns #25232

Closed
2 tasks done
davidrichardsonleit opened this issue Jun 14, 2024 · 2 comments
Closed
2 tasks done
Labels
area:scaffolder Everything and all things related to the scaffolder project area enhancement New feature or request

Comments

@davidrichardsonleit
Copy link

馃敄 Feature description

Support GitHub Environment Tag Patterns as per:

https://github.blog/changelog/2023-10-06-actions-secure-deployment-rollouts-to-protected-environments-based-on-select-tag-patterns/

馃帳 Context

Currently the action github:environment:create only supports a custom branch policy.

When releasing software tagging a commit with something like release/v1.2.0 is best practice.

But the current behaviour means that if a branch commit has a tag then it is not possible to use an environment.

鉁岋笍 Possible Implementation

No response

馃憖 Have you spent some time to check if this feature request has been raised before?

  • I checked and didn't find similar issue

馃彚 Have you read the Code of Conduct?

Are you willing to submit PR?

None

@davidrichardsonleit davidrichardsonleit added the enhancement New feature or request label Jun 14, 2024
@camilaibs camilaibs added the area:scaffolder Everything and all things related to the scaffolder project area label Jun 17, 2024
@codingdiaz
Copy link
Contributor

It looks like the API call that is creating protections is not specifying the type (might have not been available when written) and it鈥檚 defaulting to branch.

I started a draft PR to try to address it! #25333

@benjdlambert
Copy link
Member

Closing as fixed in the aforementioned PR! 馃帀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:scaffolder Everything and all things related to the scaffolder project area enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants