Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove requirements for Group model #3049

Closed
jcarres-mdsol opened this issue Oct 22, 2020 · 2 comments · Fixed by #3373
Closed

Remove requirements for Group model #3049

jcarres-mdsol opened this issue Oct 22, 2020 · 2 comments · Fixed by #3373
Labels
area:catalog Related to the Catalog Project Area enhancement New feature or request

Comments

@jcarres-mdsol
Copy link

The current group model according to the docs requires ancestors, children and descendant.

But this means that if my org is:
root => Engineering -> Platform -> Devtools -> TeamA
I need to write any of these names in 3 places. Now I want to change "Devtools" to "Internal tools" and need to do modifications in multiple places.

If you want to build a tree of the org, the only required element should be the parent, which interestingly enough is the only optional element currently

@jcarres-mdsol jcarres-mdsol added the enhancement New feature or request label Oct 22, 2020
@freben
Copy link
Member

freben commented Oct 22, 2020

It's optional only because the org root can't have a parent :)

Yep this is on the roadmap. Let's use this ticket to keep track of the progress of this aspect of it.

There is ongoing work (see recent PRs) to implement relations. The end result will be a flexible model where the input yaml can express either side of a relation, but both sides will be generated automatically.

For example, in some data sources, the parent is easily and immediately available as you say. In other data sources, the immediate children are instead easily available. Both should trivially be supported, and should lead to identical sets of relations to be produced.

Likewise, in some data sources the user's groups is easily available; in others the groups' members are easily available. You should be able to specify either one as you prefer.

As part of the ongoing work, fields like ancestors and descendants will disappear entirely, and fields like parent/children and groups/members will become optional.

@freben freben added the area:catalog Related to the Catalog Project Area label Oct 22, 2020
@freben
Copy link
Member

freben commented Nov 19, 2020

Update:

Initial relations support has been implemented.

We are considering removing the ancestors and descendants fields.

There is some interesting discussion around relations and usage around users and groups for those who may be interested here: #3293

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:catalog Related to the Catalog Project Area enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants