Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to configure SAML auth acceptedClockSkewMs #6608

Closed
stephane-mori opened this issue Jul 26, 2021 · 0 comments · Fixed by #6609
Closed

Allow to configure SAML auth acceptedClockSkewMs #6608

stephane-mori opened this issue Jul 26, 2021 · 0 comments · Fixed by #6609
Labels
enhancement New feature or request

Comments

@stephane-mori
Copy link
Contributor

SAML authentication can be configure in app-config.yaml file. Some options are available such as entryPoint, issuer or other.
acceptedClockSkewMs option is not available.

Feature Suggestion

Allow to configure SAML auth acceptedClockSkewMs

Possible Implementation

I already tried an implementation.

in plugins/auth-backend/config.d.ts b/plugins/auth-backend/config.d.ts
add acceptedClockSkewMs: number; to Config interface

in plugins/auth-backend/src/providers/saml/provider.ts b/plugins/auth-backend/src/providers/saml/provider.ts
add acceptedClockSkewMs: config.getOptionalNumber('acceptedClockSkewMs'), to SAML authentication provider options

Context

I can start to work on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant