Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs (primary level navigation) #922

Closed
katz95 opened this issue May 19, 2020 · 6 comments 路 Fixed by #1076
Closed

Tabs (primary level navigation) #922

katz95 opened this issue May 19, 2020 · 6 comments 路 Fixed by #1076
Assignees
Labels
component Reusable and standard UI design storybook https://backstage.io/storybook

Comments

@katz95
Copy link
Contributor

katz95 commented May 19, 2020

馃棐 General

Hi! Would love if someone could help us build our primary level navigation, which comes in the form of tabs! 鉁≒lease add this to our Storybook as well.

tabs

馃捇 Usage

Tabs

Horizontal tabs are the first level of navigation within a plugin or entity page on Backstage. First level navigation should be broader, and we recommend keeping the number of first level tabs to less than 8. However, if there are more tabs, we have designed a way for users to view additional tabs by clicking on the caret icon at the very right of the tab area.

We recommend that you follow the usage and interaction guidelines for tabs that Material has listed.

馃搻 Specs

Tabs Specs

馃敭 Future

We're currently brainstorming secondary and tertiary level navigation as well! We'll keep you all posted! 馃帀

@katz95 katz95 added design component Reusable and standard UI storybook https://backstage.io/storybook labels May 19, 2020
@Rugvip
Copy link
Member

Rugvip commented May 20, 2020

There's an existing component for horizontal scrolling that we should reuse: https://github.com/spotify/backstage/tree/master/packages/core/src/components/HorizontalScrollGrid

@shmidt-i
Copy link
Contributor

I think actually this is exactly what is needed +- styling:
https://material-ui.com/components/tabs/#scrollable-tabs

@ayshiff
Copy link
Contributor

ayshiff commented May 26, 2020

Can I work on it ? 馃殌

@stefanalund
Copy link
Contributor

@ayshiff for sure! I've assigned you.

@shmidt-i
Copy link
Contributor

Hey @ayshiff, just checking in to see if you need any help on this one?

@ayshiff
Copy link
Contributor

ayshiff commented May 29, 2020

Hey @shmidt-i ! Thank you, I'm almost done !

@ayshiff ayshiff mentioned this issue May 30, 2020
11 tasks
@stefanalund stefanalund moved this from To do to Review in progress in Mammalian Mathematician May 31, 2020
@stefanalund stefanalund assigned hooloovooo and unassigned hooloovooo Jun 1, 2020
Mammalian Mathematician automation moved this from Review in progress to Done Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component Reusable and standard UI design storybook https://backstage.io/storybook
Projects
Development

Successfully merging a pull request may close this issue.

6 participants