Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed dependencies that aren't always used. #39

Closed
mrrooijen opened this issue Sep 20, 2010 · 3 comments
Closed

Removed dependencies that aren't always used. #39

mrrooijen opened this issue Sep 20, 2010 · 3 comments

Comments

@mrrooijen
Copy link
Contributor

So for example, looking at our gemspec file:

##
# Dependencies
gem.add_dependency('s3',            [">= 0.3.0"])
gem.add_dependency('net-ssh',       [">= 2.0.15"])
gem.add_dependency('net-scp',       [">= 1.0.2"])
gem.add_dependency('net-sftp',      [">= 2.0.4"])
gem.add_dependency('activerecord',  [">= 2.3.5"])
gem.add_dependency('sqlite3-ruby',  [">= 1.2.5"])
gem.add_dependency('hirb',          [">= 0.2.9"])
gem.add_dependency('pony',          [">= 0.5"])
gem.add_dependency('cloudfiles',    [">= 1.4.7"])

it is going to install a bunch of things. But maybe we should not do this and instead, like how Paperclip does it. If you want to use S3 storage, and the user tries to run it, then prompt something like this:

Could not load s3 gem. Install and require it in your environment.

Instead of adding a bunch of dependencies to the gem as shown above.
For example if you could care less about CloudFiles or Pony for Email nofications, then why install it?
Install it manually or add it to gemfile if you are using Rails when needed, notify the user with a prompt when trying to load in something that doesn't exist.

Who here likes the approach? Cause maybe when working with bundler for example, it might become a dependency hell for anyone that has gems that depend on different versions of the gem above.

@fmluizao
Copy link

+1 for this. But I think this issue is a duplicate of #21 ...

@mrrooijen
Copy link
Contributor Author

I forgot all about it. :) ha you're right.

@fmluizao
Copy link

Closing, since it's duplicate.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants