config.rb/tmp_path appears to be not respected

[TemporarilyOffline]

I have tried

tmp_path '/mnt/backup'
tmp_path = '/mnt/backup'
tmp_path('/mnt/backup')

and setting --tmp_path /mnt/backup on the cli.

Setting on the CLI worked fine, the config.rb examples do not. When there are no CLI options, the tmp_path is actually root_path/.tmp. root path is specified on the command line so that it knows where to find config.rb.

[tombruijn]

tmp_path = '/mnt/backup' will not work because you're assigning a local variable there. The other two should work.

So you're already using --root-path in this scenario? But then it doesn't
Can you post your complete config please?

[TemporarilyOffline]

My command line:

/usr/bin/backup perform --trigger rotation --root-path /var/backup

My config file:

# encoding: utf-8

##
# Backup v4.x Configuration
#
# Documentation: http://meskyanichi.github.io/backup
# Issue Tracker: https://github.com/meskyanichi/backup/issues

root_path '/var/backup'
tmp_path  '/mnt/backup'
data_path '/var/backup/data'

Logger.configure do    
  console.quiet     = true            # Same as command line: --quiet
  logfile.max_bytes = 2_000_000       # Default: 500_000
  syslog.enabled    = false           # Same as command line: --syslog     
  syslog.ident      = 'BACKUP' # Default: 'backup'             
end    

Storage::S3.defaults do |s3|  
  s3.access_key_id        = "access_key_id"
  s3.secret_access_key    = "secret_access_key"  
  s3.bucket               = "bucket-name"
  s3.region               = "region"
  s3.path                 = "path"
end

[tombruijn]

@TemporarilyOffline woops.. I can confirm that this doesn't work.. Sorry about that.

The problem seems to be here:

backup/lib/backup/config.rb

Lines 44 to 45 in 2894897

	update(dsl._config_options) # from config.rb
	update(options) # command line takes precedence

Line 44: The values from your config file are set.
Line 45: Paths are overridden if they are given through the CLI.

However, the contents of that hash are:

{"config_file"=>"",
 "root_path"=>"/Users/tom/Desktop/backup",
 "data_path"=>"",
 "log_path"=>"",
 "tmp_path"=>"",
 "quiet"=>false,
 "syslog"=>false,
 "logfile"=>true,
 "check"=>false,
 "trigger"=>"issue_668"}

All the path values are empty. When they are being updated this empty value is set and then the next time backup asks for those paths it finds no value and falls back on the default.

I'll start looking for a fix. In the meantime you have to supply these paths through the CLI apparently it's the only config it really listens to.

[TemporarilyOffline]

Thanks Tom!

[tombruijn]

@TemporarilyOffline some bad news. I spend some 4 hours on this problem (I use a time tracker) and it's difficult to fix. Well not this problem, but everything else around it. The config paths have so many damn conditionals on the whole configuration section that adding another exception to it is almost impossible. I now have it down to 21 failing specs, but I'm giving up.

I can much better spend my time on the next version where we already sorted the configuration out.

I hope the workaround of setting everything on the CLI works for now.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.