Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better tracking for constant monkey patched #7

Open
backus opened this issue Oct 13, 2015 · 0 comments
Open

Better tracking for constant monkey patched #7

backus opened this issue Oct 13, 2015 · 0 comments

Comments

@backus
Copy link
Owner

backus commented Oct 13, 2015

if a dependency does the following

module SomeMethods
  def something
  end
end

include SomeMethods

then every object including BasicObject is monkey patched. The issue though is that Object.methods(false) does not pickup the monkey patched method since it originates from SomeMethods. Running Object.methods(true) though reports #something as a monkey patch in every reachable object in the VM. Therefore, monkey patch tracking should respect SomeConst.ancestors and only report patches that were introduced for the object in question but not its ancestors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant