Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FR: Dark theme for Android #6

Closed
badaix opened this issue Apr 28, 2018 · 6 comments · Fixed by #59
Closed

FR: Dark theme for Android #6

badaix opened this issue Apr 28, 2018 · 6 comments · Fixed by #59
Labels
feature request next release fixed in develop branch and will be part of the next release

Comments

@badaix
Copy link
Owner

badaix commented Apr 28, 2018

From @gerroon on January 16, 2018 17:44

Hi

It would be nice f we have a simple dark theme for Android . The current android features seems to be sufficient for now. We just need a dark theme for night use.

thanks

Copied from original issue: badaix/snapcast#346
@badaix
Copy link
Owner Author

badaix commented Apr 28, 2018

Pull requests are always welcome 😄

@badaix badaix mentioned this issue Apr 28, 2018
Closed
@Chaphasilor Chaphasilor mentioned this issue Oct 5, 2021
Open
@gsalinaslopez gsalinaslopez mentioned this issue Oct 4, 2023
Merged
@gsalinaslopez
Copy link
Contributor

Hi @badaix! I just created a pull request that implements this feature, please have a look.

Thanks!

@badaix
Copy link
Owner Author

badaix commented Apr 9, 2024

Thanks @gsalinaslopez it's merged :)

@badaix badaix added the next release fixed in develop branch and will be part of the next release label Apr 9, 2024
@badaix
Copy link
Owner Author

badaix commented Apr 22, 2024

Fixed in Snapdroid v0.28.0.1

@badaix badaix closed this as completed Apr 22, 2024
@gsalinaslopez
Copy link
Contributor

Hi @badaix

Thanks for taking the time to include this changes! I've been using snapcast on for a while now and I think is great, hopefully these changes help it to improve even more :D

@badaix
Copy link
Owner Author

badaix commented Apr 24, 2024

@gsalinaslopez thanks a lot for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request next release fixed in develop branch and will be part of the next release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add dark theme support gsalinaslopez/snapdroid
2 participants
@badaix @gsalinaslopez