Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GitHubGoMod] Ignore comment after version (fixes #10079) #10080

Merged
merged 2 commits into from Apr 7, 2024
Merged

[GitHubGoMod] Ignore comment after version (fixes #10079) #10080

merged 2 commits into from Apr 7, 2024
+27 −1

Conversation

maratori
Copy link
Contributor

@maratori maratori commented Apr 6, 2024

Fixes #10079.
Ignore a comment after the version in the go.mod file.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 6, 2024 •
edited

Warnings
⚠️ This PR modified service code for github but not its test code.
That's okay so long as it's refactoring existing code.
Messages
📖 ✨ Thanks for your contribution to Shields, @maratori!

Generated by 🚫 dangerJS against ef8681b

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 7, 2024

🚀 Updated review app: https://pr-10080-badges-shields.fly.dev

chris48s
chris48s approved these changes Apr 7, 2024
View reviewed changes
Copy link
Member

@chris48s chris48s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed some tests before merging

@chris48s chris48s added this pull request to the merge queue Apr 7, 2024
Merged via the queue into badges:master with commit caea759 Apr 7, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris48s chris48s chris48s approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GitHub go.mod Go version contains comment
2 participants
@maratori @chris48s