improve performance of getIconSize() #10125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Updated review app: https://pr-10125-badges-shields.fly.dev |
|
🚀 Updated review app: https://pr-10125-badges-shields.fly.dev |
|
that appears to have done the job 😌 |
|
I can't believe I made such trouble... 😓 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I attempted to deploy #9191
This happened
There's something in that change that has caused a big performance issue.
I haven't really benchmarked this, but my instinct is that loading the whole simple-icons set every time we invoke
getIconSize()is at least part of the problem.This PR moves to doing this once at module load time instead of every time we call the function.