Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for docker secrets #1778

Open
Vampire opened this issue Jul 13, 2018 · 3 comments
Open

Support for docker secrets #1778

Vampire opened this issue Jul 13, 2018 · 3 comments
Labels
self-hosting Discussion, problems, features, and documentation related to self-hosting Shields

Comments

@Vampire
Copy link

Vampire commented Jul 13, 2018

It would be great if the docker image would support docker secrets, so that things like GitHub credentials can be safely stored without building them into the image or providing them through environment variables.

@paulmelnikow paulmelnikow added the self-hosting Discussion, problems, features, and documentation related to self-hosting Shields label Jul 14, 2018
@paulmelnikow
Copy link
Member

paulmelnikow commented Jul 16, 2018

Hi! Thanks for the suggestion. Would be great to support this. Do you know what's involved? Would you be interested in working on it?

@Vampire
Copy link
Author

Vampire commented Jul 17, 2018

You can find more information at https://docs.docker.com/engine/swarm/secrets/ and especially https://docs.docker.com/engine/swarm/secrets/#build-support-for-docker-secrets-into-your-images.

Basically you just have to support configuring files from which confidential information is read instead of configuring the confidential data themselves.

@paulmelnikow
Copy link
Member

Some relevant discussion / implementation in #2621 and #2626. These don't address docker secrets directly, though we could implement those with docker secrets in mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
self-hosting Discussion, problems, features, and documentation related to self-hosting Shields
Projects
None yet
Development

No branches or pull requests

2 participants