Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gmodstore.com Integration / what badges are in scope for Shields #1946

Closed
pointydev opened this issue Aug 19, 2018 · 2 comments
Closed

gmodstore.com Integration / what badges are in scope for Shields #1946

pointydev opened this issue Aug 19, 2018 · 2 comments
Labels
documentation Developer and end-user documentation

Comments

@pointydev
Copy link

Hey there peeps,

Just looking for some opinions on having some badges for https://gmodstore.com so we could have premade version and rating shields to put on script info pages. They have an API which ya can find here: https://www.gmodstore.com/help/api/

I'll probably be making an implementation later if others don't disagree (per advice from @PyvesB), so feel free to give feedback.

Thanks,
Elliott

@paulmelnikow paulmelnikow added the service-badge Accepted and actionable changes, features, and bugs label Aug 19, 2018
@paulmelnikow
Copy link
Member

paulmelnikow commented Aug 19, 2018

To summarize what I said in Discord:

  • With two caveats, this is the answer i gave last year to a question about what's in scope for shields: [Question] Acceptable types of badges #1169 (comment)
  • First caveat: is using gmod programming, or widely used by game developers? that would make a good argument that it's in scope.
  • Second caveat: we've a languishing PR [badge-json] new "badge-json" service #1525 which contains a bunch of good design work on a new way of specifying a dynamic badge. We could revive that, and update it to harmonize with new-style services. Combined with Runkit endpoints which look absolutely fabulous, folks who want to can use shields as a rendering and caching provider that sits in front of a runkit endpoint. (Badgen has this.)
  • Shields is open source but there's no requirement that the tools be open source. lots of them aren't

@pointydev's response:

well gmod is a highly moddable game which involves a dev codebase behind it all, and gmodstore (my suggestion) is a marketplace for developers to sell their addons and services, its primary purpose

That seems to place it solidly in the realm of the other app stores, like chrome web store, etc.

This could all be made clearer in CONTRIBUTING.md, which talks about inclusion guidelines for logos, but not badges.

Our page title on https://shields.io/ could possibly make it clearer as well, that this is a tool for developers, including but not exclusive to open source development.

@paulmelnikow paulmelnikow added the developer-experience Dev tooling, test framework, and CI label Aug 19, 2018
@paulmelnikow paulmelnikow changed the title gmodstore.com Integration gmodstore.com Integration / what badges are in scope for Shields Aug 19, 2018
@paulmelnikow paulmelnikow added documentation Developer and end-user documentation and removed developer-experience Dev tooling, test framework, and CI service-badge Accepted and actionable changes, features, and bugs labels Jan 8, 2019
@paulmelnikow
Copy link
Member

Looks like this was documented in #2042.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Developer and end-user documentation
Projects
None yet
Development

No branches or pull requests

2 participants