New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
flat: rounded corners #228
Comments
Thanks for reporting! Indeed, the change is normal. However, I am eager for feedback. I am merging this issue to the original one: #185 |
@espadrine thank you for this information :D |
I have been confused by the style change (I thought that I forgot to update one of my repos to the flat style). Personally I would keep the flat style without gradients and shadows (Google material guidelines are not strictly flat from my understanding). I like the change to round corners but, given the size of the element I would reduce the radius to the minimum possible amount. |
The main thread on this subject is here: #185 A few people have indicated interest in having the option to keep using the old design, which is why I have started work to support both. It is not yet live, because I still need to add it to analytics, but you'll know when it is if you subscribe to the thread linked above. I'll look at which badge design is the most popular in order to eventually switch the default badge design. I am not sure how to deal with middle grounds between the old flat design and the new one. That feedback is obviously very welcome, but I don't have a good way to submit this to a "real" vote. I could add more and more badge styles to be used, with an indication of the choice on the front page, but if there are too many choices, the order of the badges becomes a discriminating factor and makes the whole choice moot. We have a choice between two currently; I'll add a badge with rounded corners + no gradients + no shadows if someone else asks for it, or maybe I'll make a small poll between all the combinations of rounded corners, gradients and shadows. |
I read the discussion on the main thread and I just wanted to post my take. Adding support to the old flat style via a different modifier would be inconvenient to me because I would need to change all the badges in the repos I contribute to (CocoaPods). I think that the new style should have carried a new modifier unless intended to replace the old flat one. Regarding options, I as an OSS contributor try to fight back them as hard as I can 😄 Thanks for the great project @espadrine. |
I noticed a change on the flat design, no more square but rounded corners, this is normal?
Sorry for my bad english.
The text was updated successfully, but these errors were encountered: