Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caching layer for discardable credentials #2547

Open
paulmelnikow opened this issue Dec 17, 2018 · 0 comments
Open

Caching layer for discardable credentials #2547

paulmelnikow opened this issue Dec 17, 2018 · 0 comments
Labels
core Server, BaseService, GitHub auth operations Hosting, monitoring, and reliability for the production badge servers performance-improvement Related to performance or throughput of the badge servers

Comments

@paulmelnikow
Copy link
Member

API credentials for the Matrix badge work by creating a guest user. It would be better for performance reasons of the badge and the server not to create a guest user for each request, but to create one once and use it for all requests.

In #2527 (comment) I described an adaptation of the GitHub FsTokenPersistence/RedisTokenPersistence storage layer to support Matrix.

The other places caching has arisen are for Gitlab #1838 which is similar to GitHub, and #1545 which is about caching of intermediate API responses. As I think about the Matrix use case some more, it seems possible that it's better to think of these as intermediate responses, since unlike GitHub and Gitlab API keys, they are discardable.

See also this discussion: #1848 (comment)

Dependencies: #1848 #1806

@paulmelnikow paulmelnikow added core Server, BaseService, GitHub auth operations Hosting, monitoring, and reliability for the production badge servers labels Dec 17, 2018
@paulmelnikow paulmelnikow added the performance-improvement Related to performance or throughput of the badge servers label Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Server, BaseService, GitHub auth operations Hosting, monitoring, and reliability for the production badge servers performance-improvement Related to performance or throughput of the badge servers
Projects
None yet
Development

No branches or pull requests

1 participant