-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Symfony Insight Badges show "invalid response data" on projects that haven't been analyzed recently #2928
Comments
The root cause is that our schema validation for Symfony Insight is expecting there to be a value for I think we'll need to relax the schema a bit |
@arcanedev-maroc by any chance do you have any guesses as to why there's no status values for those projects? We use the value of the status field to handle scenarios when a badge is requested for a project that is mid-analysis, so I want to make sure we don't break that. Would you be willing to re-run an analysis on one of your projects so that I can check the values before/during/after analysis? I don't use the service myself but would love to get this fixed, and that'd be a big help! |
I have no idea about the status values ! I've been using the badges for years with a default project I've just re-run manually the analysis on one of my projects: https://insight.symfony.com/projects/ae37b4c0-5478-4afb-9a71-1fe5534d8ef5/analyses/106 |
Perfect thanks! The Symfony API response now has a status value of The badges are working for that project now: https://img.shields.io/symfony/i/violations/ae37b4c0-5478-4afb-9a71-1fe5534d8ef5.svg?style=flat In the short term I think the easiest way to get the badges working again for your project would be to re-run analyses on them. My guess is that the |
Yes indeed, i re-ran the analysis and it's seems the problem was solved for the projects i've mentioned. Thanks for your work & time 👍 |
Hey @bkdotcom do you have any projects using Symfony Insight you could share? I'm trying to determine the range of values we can expect to see in the API response, in particular for projects that haven't been analyzed in a while (ideally not analyzed for a few weeks/months). I don't use the service myself, and the projects listed in the Public Analysis section have all been run within the last few hours. |
Hi @calebcartwright, You can check my organization's profile: https://github.com/ARCANEDEV It has some old repos with Symfony Insight. |
Just an FYI that I've added a fix for this in #2971 (which is also adding a Stars badge for Symfony Insight) |
Are you experiencing an issue with...
🪲 Description
I saw this problem on multiple PHP projects that are using symfony/insight and i have no clue what is the issue.
🔗 Link to the badge
https://img.shields.io/sensiolabs/i/ae37b4c0-5478-4afb-9a71-1fe5534d8ef5.svg?style=flat-square
Repos
The text was updated successfully, but these errors were encountered: