Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite high-level color override tests in core #3068

Open
paulmelnikow opened this issue Feb 21, 2019 · 1 comment
Open

Rewrite high-level color override tests in core #3068

paulmelnikow opened this issue Feb 21, 2019 · 1 comment
Labels
core Server, BaseService, GitHub auth

Comments

@paulmelnikow
Copy link
Member

The dynamic JSON, XML, and YAML services have service tests for color override functionality which is in BaseService. The low-level functionality is checked in coalesceBadge which is fine, though there probably should be a higher-level test for BaseService.

These tests should be removed from dynamic-*.tester.js.

Ref: #3066 (comment)
@paulmelnikow paulmelnikow added the core Server, BaseService, GitHub auth label Feb 21, 2019
@paulmelnikow paulmelnikow mentioned this issue Feb 21, 2019
Merged
@paulmelnikow
Copy link
Member Author

paulmelnikow commented Apr 13, 2019 •
edited

I removed them from dynamic XML just now: #3298.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core Server, BaseService, GitHub auth
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@paulmelnikow