Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display decimals when over 1 million #3509

Closed
heaths opened this issue May 29, 2019 · 2 comments 路 Fixed by #3735
Closed

Display decimals when over 1 million #3509

heaths opened this issue May 29, 2019 · 2 comments 路 Fixed by #3735
Assignees
Labels
good first issue New contributors, join in! service-badge Accepted and actionable changes, features, and bugs

Comments

@heaths
Copy link

heaths commented May 29, 2019

馃搵 Description

Once downloads hit 1 million, the resolution of downloads is simply an integer, e.g. 1M. Pretty big milestone for some projects, but getting to display 2M might take just as long if not longer. What about showing a single decimal digit, e.g. 1.2M which still fits within limits. Perhaps this drops off after 10M. Same would go for billions, etc.

@calebcartwright calebcartwright added the question Support questions, usage questions, unconfirmed bugs, discussions, ideas label May 30, 2019
@calebcartwright
Copy link
Member

That sounds reasonable to me!

If anyone is interested in having a look at implementing this, the download count badges leverage the metric formatter found here that would need to be updated to support this

@calebcartwright calebcartwright added good first issue New contributors, join in! service-badge Accepted and actionable changes, features, and bugs and removed question Support questions, usage questions, unconfirmed bugs, discussions, ideas labels Jun 5, 2019
@PyvesB
Copy link
Member

PyvesB commented Jun 8, 2019

This seems like a reasonable request to me as well. However, I personally think we should be consistent, and do the same for k, G, T, P as well, e.g. 1.2k. The same "big milestone" rational applies to them as well. 馃槈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue New contributors, join in! service-badge Accepted and actionable changes, features, and bugs
Projects
None yet
3 participants