Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove the cacheSeconds/maxAge param #3596

Open
chris48s opened this issue Jun 22, 2019 · 0 comments
Open

remove the cacheSeconds/maxAge param #3596

chris48s opened this issue Jun 22, 2019 · 0 comments
Labels
needs-discussion A consensus is needed to move forward

Comments

@chris48s
Copy link
Member

In some previous discussions, we've talked about maybe removing the ability for the user to manually pass a cacheSeconds/maxAge param once we've got rid of all the legacy services:

#2205 (comment)
#2755 (comment)

This param was introduced before we were using a CDN to cache at all and works around a performance problem which we've mostly now fixed. Now that we don't have any legacy services left every badge should have a sensible downstream cache length defined (based on the badge category: build, version, license, etc). I think now it is reasonable to retire that feature and simplify our internals a bit.

I don't mind taking this on, but its a bit of a fiddly job, so I'd like to make sure we're agreed that is a sensible thing to do before I start on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-discussion A consensus is needed to move forward
Projects
None yet
Development

No branches or pull requests

1 participant