Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate treatment of whitespace in route parameters #5012

Open
paulmelnikow opened this issue May 1, 2020 · 0 comments
Open

Investigate treatment of whitespace in route parameters #5012

paulmelnikow opened this issue May 1, 2020 · 0 comments
Labels
core Server, BaseService, GitHub auth

Comments

@paulmelnikow
Copy link
Member

Brought to our attention via a production bug #4982: at least this badge accepts trailing spaces in the route parameter. A brief discussion ensued at #4983 (comment).

I imagined, and still do, that most of our routes should be limited to characters like A-Za-z0-9_-. Most usernames, project names, etc. cannot include whitespace.

We may want to think about a global change to the default route-component regex, with overrides in places where whitespace is acceptable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Server, BaseService, GitHub auth
Projects
None yet
Development

No branches or pull requests

1 participant