-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problems with using StackOverflow reputation badge #5415
Comments
Thanks for the report. Weird! This issue is very strange, and must be related either to the Shields onboard caching logic (or possibly the CDN, though I doubt it). I expect it will resolve itself whenever the bad data is evicted from the cache. It works fine locally and on staging. If the underlying issue is the onboard cache, probably the best solution is to remove that cache, something I've wanted to do anyway. (#3368) |
Thank you. It did resolve itself for the next day. |
Wild speculation, but I wonder if this is a manifestation of #3591 ? from https://api.stackexchange.com/docs/throttle :
I guess we could be getting rejected with a 400 for making too many requests (which might explain this error and the intermittent behaviour) |
I have the same issue, they work and stop working randomly |
@chris48s I guess I’m confused that we’re getting “invalid parameter” on this, which sounds like, in addition to needing more rate limit, there’s also a bug in that we return what sounds like a permanent error instead of “unreachable.” |
The message "invalid parameters" implies we're getting a 400 response from the upstream API based on the code: shields/services/stackexchange/stackexchange-reputation.service.js Lines 66 to 68 in 1047fd9
We don't know why that is happening. It would indeed be conventional for a 400 response to indicate that we are issuing an invalid or erroneous request. It would also be conventional to reject a request with something like a 429 if a rate limit has been exceeded. The reason I suggested the 400 might be rate-limit related in this case is because of that quote from the documentation I posted:
but I don't really know. |
Ah, I gotcha. It’s too bad they seem to send a 400 for both things! |
Any update on this? |
Let me know if you want some help with the rate limiting. |
Yes. We'd love to find out if the issue we're seeing is rate limit related or not. We make all our requests with a user agent starting |
Have you registered with https://stackapps.com/? That would get you higher throttling limits. I do see your requests and I'll poke around some more on Monday. |
No. I was not aware it existed. We're making all our requests with no auth. I'll have a look into this 👍 |
PR up at #8539 |
Has this been resolved because I'm still seeing "invalid parameters" instead of the reputation count? |
#8539 is still open waiting on review |
you experiencing an issue with...
🪲 Description
When I use StackOverflow reputation badge without any parameters everything works okay:
But when I add parameters in order to change badge color or shape, it says there's
invalid parameters
Also, if I want to change title from
stackoverflow reputation
toStackOverflow reputation
:🔗 Link to the badge
💡 Possible Solution
¯_(ツ)_/¯
The text was updated successfully, but these errors were encountered: