Use NPM packages to provide fonts instead of Google Fonts #6274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This patch uses the fontsource libraries instead of using Google Fonts in order to provide the fonts in the frontend. This way the web frontend becomes more private, since it no longer shared visitors IPs with Google and might even loads faster since modern web browsers isolate site caches from each other and can re-use connections with HTTP/2 instead of setting up a new connection to Google.[1] It's basically the next iteration of my previous PR[2], that no longer relies on a tool to download the fonts separately, but uses a library instead. It also relates to issues that have been opened before[3] and should be easily handled and upgraded by the regular NPM package tooling[4], solving all related problems to that. [1]: https://csswizardry.com/2019/05/self-host-your-static-assets/ [2]: badges#4864 [3]: badges#5883 [4]: https://github.com/badges/shields/labels/dependencies
SISheogorath
force-pushed
the
feature/self-hosted-fonts
branch
from
a53bd35
to
4aad35b
Compare
calebcartwright
added
frontend
PyvesB
approved these changes
Mar 16, 2021
There was a problem hiding this comment.
Thanks for the contribution @SISheogorath! 👍🏻
@badges/shields-ops briefly discussed this in a meeting, we have no fundamental concerns with the proposed approach.
I've checked things in the Heroku review app, and could not spot any regressions. The fontsource project seems quite well organised and in a good shape. I'm going to go ahead and merge this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch uses the fontsource libraries instead of using Google Fonts
in order to provide the fonts in the frontend. This way the web frontend
becomes more private, since it no longer shared visitors IPs with Google
and might even loads faster since modern web browsers isolate site
caches from each other and can re-use connections with HTTP/2 instead of
setting up a new connection to Google.[1]
It's basically the next iteration of my previous PR[2], that no longer
relies on a tool to download the fonts separately, but uses a library
instead. It also relates to issues that have been opened before[3] and
should be easily handled and upgraded by the regular NPM package
tooling[4], solving all related problems to that.
1: https://csswizardry.com/2019/05/self-host-your-static-assets/Related to dependency updates
2: #4864
3: #5883
4: dependencies
Note: I'm not sure what to put into the brackets for the PR title, but I hope it's fine this way.