Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YouTube tests intermittently failing #6276

Closed
PyvesB opened this issue Mar 16, 2021 · 2 comments
Closed

YouTube tests intermittently failing #6276

PyvesB opened this issue Mar 16, 2021 · 2 comments
Assignees
Labels
keep-service-tests-green Related to fixing failing tests of the services

Comments

@PyvesB
Copy link
Member

PyvesB commented Mar 16, 2021

🕚 When did the problem start?

Unsure on the exact date, the errors have been intermittent for several months as far as I can tell. Some problems were already reported here: #5842

📷 Live badge

https://img.shields.io/youtube/likes/abBdk8bSPKU?style=social

🔧 Is the live badge working?

The live badge is intermittently failing as well.

🔗 CircleCI link

https://app.circleci.com/pipelines/github/badges/daily-tests/833/workflows/eeeaf314-50d4-4e5c-83fe-c2f02c5d7197/jobs/1731

🪲 Stack trace

AssertionError: label mismatch: expected 'youtube' to equal 'votes'
    at Function._expectField (core/service-test-runner/icedfrisby-shields.js:69:51)
    at IcedFrisbyNock.<anonymous> (core/service-test-runner/icedfrisby-shields.js:53:26)
    at IcedFrisbyNock.<anonymous> (node_modules/icedfrisby/lib/icedfrisby.js:954:10)
    at invokeNextHook (node_modules/icedfrisby/lib/icedfrisby.js:1003:24)
    at /home/circleci/project/shields/node_modules/icedfrisby/lib/icedfrisby.js:1017:7
    at new Promise (<anonymous>)
    at IcedFrisbyNock._runHooks (node_modules/icedfrisby/lib/icedfrisby.js:976:12)
    at IcedFrisbyNock.run (node_modules/icedfrisby/lib/icedfrisby.js:1276:20)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:97:5)
    at async Context.<anonymous> (node_modules/icedfrisby/lib/icedfrisby.js:1348:9)

💡 Possible solution

We seem to be hitting the YouTube API rate limits. According to the API console:
youtube-errors

The badges have gotten quite popular given that there are over 20000 requests per day with badges that were added less than a year ago!

We will basically need to follow the steps I documented here: #5101 (comment)

@PyvesB PyvesB added the keep-service-tests-green Related to fixing failing tests of the services label Mar 16, 2021
@PyvesB PyvesB self-assigned this Mar 17, 2021
@PyvesB
Copy link
Member Author

PyvesB commented Mar 17, 2021

I've submitted the Quota Extension Form. Was more tedious than expected, new fields appear in the form as you select options. Let's see what comes out of it!

@PyvesB
Copy link
Member Author

PyvesB commented Apr 1, 2021

Great news! There's been a bit of back and forth with the YouTube compliance team initially not noticing the changes conducted as part of #6304, but after two weeks, I managed to get our quota increased from 10000 to 50000 daily requests. We may need to do a new increase request in a few months or years, but I would expect the process to be much more straightforward the second time round, provided our implementation remains at the same level of compliance.

The last few daily tests have not failed, and API errors are no longer being reported:
youtube-no-more-errors

Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keep-service-tests-green Related to fixing failing tests of the services
Projects
None yet
Development

No branches or pull requests

1 participant