Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Netlify badge down #6334

Closed
1 of 3 tasks
adamalston opened this issue Mar 29, 2021 · 7 comments 路 Fixed by #6340
Closed
1 of 3 tasks

Netlify badge down #6334

adamalston opened this issue Mar 29, 2021 · 7 comments 路 Fixed by #6340
Labels
bug Bugs in badges and the frontend service-badge Accepted and actionable changes, features, and bugs

Comments

@adamalston
Copy link

Are you experiencing an issue with...

馃 Description

The Netlify badge appears to be down.

馃敆 Link to the badge

Netlify Status

![Netlify Status](https://img.shields.io/netlify/332bbd91-59b7-4091-8781-6f41330399b4)

For comparison, here is the badge that Netlify provides.

Netlify Status

![Netlify Status](https://api.netlify.com/api/v1/badges/332bbd91-59b7-4091-8781-6f41330399b4/deploy-status)

Notice that both project id's are the same.

馃挕 Possible Solution

@adamalston adamalston added the question Support questions, usage questions, unconfirmed bugs, discussions, ideas label Mar 29, 2021
@chris48s chris48s added bug Bugs in badges and the frontend and removed question Support questions, usage questions, unconfirmed bugs, discussions, ideas labels Mar 30, 2021
@chris48s
Copy link
Member

Service tests for netlify are also failing.
The netlify badge is based on scraping netlify's badges so I guess their format has changed a bit and we need to update the code which extracts the status value from their SVG.

@chris48s chris48s added the service-badge Accepted and actionable changes, features, and bugs label Mar 30, 2021
@tarun7singh
Copy link
Contributor

I would like to work on this. Should I start work on the fix?

@calebcartwright
Copy link
Member

Please do @tarun7singh!

@tarun7singh
Copy link
Contributor

tarun7singh commented Mar 31, 2021

I mistakenly added the fix to this issue in my previous pull request.
PR
What should do to remove it from there and add to a new PR, or should i leave it be?

@calebcartwright
Copy link
Member

What should do to remove it from there and add to a new PR, or should i leave it be?

Yes, please remove the netlify commit from the youtube PR and open a separate PR for the netlify changes to keep things separate.

@PyvesB
Copy link
Member

PyvesB commented Apr 2, 2021

@tarun7singh's fix has been successfully deployed to production! 馃嵕

@tarun7singh
Copy link
Contributor

Thanks @PyvesB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs in badges and the frontend service-badge Accepted and actionable changes, features, and bugs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants