Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert decamelize and humanize-string to old versions #7449

Merged
merged 3 commits into from
Jan 6, 2022
Merged

revert decamelize and humanize-string to old versions #7449

merged 3 commits into from
Jan 6, 2022

Conversation

chris48s
Copy link
Member

@chris48s chris48s commented Jan 5, 2022 •
edited
Loading

closes #7447
closes #7324

@chris48s chris48s added frontend The React app and the infrastructure that supports it dependencies Related to dependency updates labels Jan 5, 2022
@shields-cd shields-cd temporarily deployed to shields-staging-pr-7449 January 5, 2022 21:14 Inactive
@shields-ci
Copy link

shields-ci commented Jan 5, 2022 •
edited
Loading

Messages
📖 ✨ Thanks for your contribution to Shields, @chris48s!

Generated by 🚫 dangerJS against 7389a7c

This was referenced Jan 5, 2022
Closed
Closed
calebcartwright
calebcartwright previously approved these changes Jan 5, 2022
View reviewed changes
Copy link
Member

@calebcartwright calebcartwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like this may not address some specific issues, but given the linked upstream issue it seems like we may want to downgrade this regardless so providing an approval accordingly

LitoMore
LitoMore suggested changes Jan 6, 2022
View reviewed changes
package.json Outdated Show resolved Hide resolved
@chris48s chris48s temporarily deployed to shields-staging-pr-7449 January 6, 2022 19:10 Inactive
@LitoMore
Copy link
Contributor

LitoMore commented Jan 6, 2022 •
edited
Loading

The title and description of the PR need to be updated.

LitoMore
LitoMore suggested changes Jan 6, 2022
View reviewed changes
Copy link
Contributor

@LitoMore LitoMore left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove the ^ mark to make sure dependabot will not update these dependencies by accident.

And please rerun npm ci after these suggestions are applied to ensure that the lockfile is up to date.

package.json Show resolved Hide resolved
package.json Show resolved Hide resolved
@chris48s
Copy link
Member Author

chris48s commented Jan 6, 2022

Dependabot bumps dependencies even if they're pinned in package.json e.g: https://github.com/badges/shields/pull/7431/files
Assuming we get a confirmation on #7447 I'll add entries to

shields/.github/dependabot.yml

Line 11 in 4fef133

ignore:
to tell dependabot to ignore them

@chris48s chris48s changed the title downgrade decamelize to v5 revert decamelize and humanize-string to old versions Jan 6, 2022
calebcartwright
calebcartwright approved these changes Jan 6, 2022
View reviewed changes
Copy link
Member

@calebcartwright calebcartwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@calebcartwright
Copy link
Member

Let's go ahead and merge+deploy

@calebcartwright calebcartwright merged commit 3d9d53b into badges:master Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LitoMore LitoMore LitoMore requested changes

@calebcartwright calebcartwright calebcartwright approved these changes

Assignees
No one assigned
Labels
dependencies Related to dependency updates frontend The React app and the infrastructure that supports it
Projects
None yet
Milestone
No milestone
5 participants
@chris48s @shields-ci @LitoMore @calebcartwright @shields-cd