Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Telegram' logo does not respect logoColor value #7576

Closed
Welding-Torch opened this issue Feb 5, 2022 · 4 comments
Closed

'Telegram' logo does not respect logoColor value #7576

Welding-Torch opened this issue Feb 5, 2022 · 4 comments
Labels
question Support questions, usage questions, unconfirmed bugs, discussions, ideas

Comments

@Welding-Torch
Copy link

Are you experiencing an issue with...

shields.io

馃悶 Description

So basically, while I was trying to fancy up my GitHub readme with some badges, I added Instagram first and then I added Telegram. Now I realised that I could use the logoColor property on Instagram (for example https://img.shields.io/badge/-Instagram-red?color=DD2A7B&logo=instagram&logoColor=white to make the Instagram logo become white. But when I tried to make the Telegram logo white, I realised that the Telegram logo remains blue regardless of logoColor.

This is a bit of an annoying problem seeing as how I'm trying to give the badges in my ReadMe a consistent look, and the Telegram logo sticks out like a sore thumb.

馃敆 Link to the badge

https://simpleicons.org/icons/telegram.svg

And for reference help: https://simpleicons.org/icons/instagram.svg

Images for visual help:
image

image

The code for the image directly above is:

![Telegram](https://img.shields.io/badge/-telegram-red?color=white&logo=telegram&logoColor=black)
![Instagram](https://img.shields.io/badge/-Instagram-red?color=white&logo=instagram&logoColor=black)

As you can see, while the logo color for the Instagram logo changes, the logo color for Telegram does not.

馃挕 Possible Solution

Possible solution: Talk to the people who run the Simple Icons API and let them know about this problem and ask them to fix it.

@Welding-Torch Welding-Torch added the question Support questions, usage questions, unconfirmed bugs, discussions, ideas label Feb 5, 2022
@calebcartwright
Copy link
Member

That's by design as we use a custom logo for telegram that takes preference over the SI reference. I believe the underlying calculus, which led us to keep telegram as one of the handful of custom logos we maintain, remains unchanged so I don't anticipate changing anything on our side.

In this case I think your best bet is to get the logo you want (via SI or otherwise) and adjust the color as needed, and then leverage our custom logo feature to embed that version in your badge

https://github.com/badges/shields/blob/master/doc/logos.md
#2510
#2880

@PyvesB
Copy link
Member

PyvesB commented Feb 6, 2022

This is by and large a duplicate of #6208, shall we continue the discussion there?

@calebcartwright
Copy link
Member

Agreed, closing

@chris48s
Copy link
Member

update: #6208 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Support questions, usage questions, unconfirmed bugs, discussions, ideas
Projects
None yet
Development

No branches or pull requests

4 participants