Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix docker image user agent #7582

Merged
merged 1 commit into from Feb 9, 2022
Merged

fix docker image user agent #7582

merged 1 commit into from Feb 9, 2022
+8 −2

Conversation

chris48s
Copy link
Member

@chris48s chris48s commented Feb 8, 2022

Closes #7573

${GITHUB_SHA::7} is a bash subscript syntax, so we need to run it with bash and write it to a var

@chris48s chris48s added bug Bugs in badges and the frontend self-hosting Discussion, problems, features, and documentation related to self-hosting Shields labels Feb 8, 2022
@shields-ci
Copy link

Messages
📖 ✨ Thanks for your contribution to Shields, @chris48s!

Generated by 🚫 dangerJS against dbd0230

calebcartwright
calebcartwright approved these changes Feb 8, 2022
View reviewed changes
Copy link
Member

@calebcartwright calebcartwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't think of any easy way to readily test this, but it looks like the right change to me anyway

@chris48s
Copy link
Member Author

chris48s commented Feb 9, 2022

Can't think of any easy way to readily test this

Yeah this was a bit of a PITA to figure out.
If you're interested, the commits/builds I used to work this out were https://github.com/badges/shields/compare/ua-debug 😆

@chris48s chris48s merged commit 5fa18e1 into badges:master Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calebcartwright calebcartwright calebcartwright approved these changes

Assignees
No one assigned
Labels
bug Bugs in badges and the frontend self-hosting Discussion, problems, features, and documentation related to self-hosting Shields
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docker Image serves incorrect User-Agent
3 participants
@chris48s @shields-ci @calebcartwright