Update [amo] to use v4 API, set custom cacheLengths
#7586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris48s
added
the
service-badge
chris48s
commented
Feb 10, 2022
| @@ -21,7 +21,7 @@ class BaseAmoService extends BaseJsonService { | |||
| async fetch({ addonId }) { | |||
| return this._requestJson({ | |||
| schema, | |||
| url: `https://addons.mozilla.org/api/v3/addons/addon/${addonId}/`, | |||
| url: `https://addons.mozilla.org/api/v4/addons/addon/${addonId}/`, | |||
There was a problem hiding this comment.
There were no breaking changes from v3 to v4 affecting any of the values we use on any of these badges
| @@ -14,6 +14,8 @@ export default class AmoUsers extends BaseAmoService { | |||
| }, | |||
| ] | |||
|
|
|||
| static _cacheLength = 21600 | |||
There was a problem hiding this comment.
@calebcartwright based on your comment in #7584 (comment) I've set downloads/users to 21600 seconds (6 hours). Feel free to tweak it if you want.
There was a problem hiding this comment.
No concerns, if anything I'd view this as a reasonable floor. I'd be open to cranking it up a bit too (especially if we need to investigate more load reduction avenues), but think that a full day would have been too much given there'd be windows of proximity to the upstream daily update where the badge could be noticeably outdated for nearly 24 hours
PyvesB
approved these changes
Feb 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7584