Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support [HexPM] packages with no stable release #7685

Merged
merged 3 commits into from Mar 5, 2022

Conversation

PyvesB
Copy link
Member

@PyvesB PyvesB commented Mar 5, 2022

Fixes #7658. Also polished the code a little by using our standard version helpers in the implementation and tests.

@PyvesB PyvesB added the service-badge Accepted and actionable changes, features, and bugs label Mar 5, 2022
@shields-ci
Copy link

shields-ci commented Mar 5, 2022

Messages
📖 ✨ Thanks for your contribution to Shields, @PyvesB!

Generated by 🚫 dangerJS against cdb10fe

@PyvesB
Copy link
Member Author

PyvesB commented Mar 5, 2022

I seem to have hit a bug with Prettier, it needs to be run twice on my changes to get the formatting right. Reported at prettier/prettier#12392.

@calebcartwright
Copy link
Member

I seem to have hit a bug with Prettier, it needs to be run twice on my changes to get the formatting right. Reported at prettier/prettier#12392.

👍 idempotence issues are a pain

@PyvesB PyvesB merged commit 03111e9 into badges:master Mar 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service-badge Accepted and actionable changes, features, and bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hex.pm badges display "invalid response data" when a package has never had a stable release
3 participants