Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support [CodeClimate] responses with multiple data items #7716

Merged
merged 2 commits into from Mar 12, 2022

Conversation

PyvesB
Copy link
Member

@PyvesB PyvesB commented Mar 12, 2022

Fixes #7695.

@PyvesB PyvesB added bug Bugs in badges and the frontend service-badge Accepted and actionable changes, features, and bugs labels Mar 12, 2022
@shields-ci
Copy link

shields-ci commented Mar 12, 2022

Messages
📖 ✨ Thanks for your contribution to Shields, @PyvesB!

Generated by 🚫 dangerJS against 81ed91c

@shields-cd shields-cd temporarily deployed to shields-staging-pr-7716 March 12, 2022 10:32 Inactive
const repoInfosWithTestReport = repoInfos.filter(
repoInfo => repoInfo.relationships.latest_default_branch_test_report.data
)
if (repoInfosWithTestReport.length === 0) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally curious what the response would represent if there were multiple entries that had test reports 🤷‍♂️

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll know when and if a future user complains! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs in badges and the frontend service-badge Accepted and actionable changes, features, and bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CodeClimate badges returning "Invalid response data" for one repo
4 participants