Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stringify and trim whitespace from a few services [gem swagger githubissues githubmilestone opencollective] #7880

Merged
merged 2 commits into from Apr 22, 2022

Conversation

paulmelnikow
Copy link
Member

Noticed these in the service test run for #7877. Whatever we decide to do there about the whitespace trimming behavior, it seems like this is a desirable change to these service implementations.

@paulmelnikow paulmelnikow added the service-badge Accepted and actionable changes, features, and bugs label Apr 22, 2022
@shields-ci
Copy link

shields-ci commented Apr 22, 2022

Warnings
⚠️ This PR modified service code for swagger but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for github but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for gem but not its test code.
That's okay so long as it's refactoring existing code.
Messages
📖 ✨ Thanks for your contribution to Shields, @paulmelnikow!

Generated by 🚫 dangerJS against 55c9957

@paulmelnikow paulmelnikow merged commit 1fcc7e4 into master Apr 22, 2022
@paulmelnikow paulmelnikow deleted the trim-whitespace branch April 22, 2022 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service-badge Accepted and actionable changes, features, and bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants