Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gitlab badge. not respecting logoColor #8139

Closed
davidmpaz opened this issue Jun 29, 2022 · 3 comments
Closed

Gitlab badge. not respecting logoColor #8139

davidmpaz opened this issue Jun 29, 2022 · 3 comments
Labels
question Support questions, usage questions, unconfirmed bugs, discussions, ideas

Comments

@davidmpaz
Copy link

Are you experiencing an issue with...

shields.io

🐞 Description

Hi,

When specifying logoColor for the icon, this is not taken into account. Notice please the difference with the one for Github:

Github
https://img.shields.io/badge/CICD-Github-informational?style=flat&logo=github&logoColor=white&color=FFFFFF
CICD

Gitlab
https://img.shields.io/badge/CICD-Gitlab-informational?style=flat&logo=gitlab&logoColor=white&color=FFFFFF
CICD

Many thanks in advance for this project.

Cheers,
David

🔗 Link to the badge

https://img.shields.io/badge/CICD-Gitlab-informational?style=flat&logo=gitlab&logoColor=white&color=FFFFFF

💡 Possible Solution

No response

@davidmpaz davidmpaz added the question Support questions, usage questions, unconfirmed bugs, discussions, ideas label Jun 29, 2022
@chris48s
Copy link
Member

The reason for this is there are a small number of icons where we use a custom multi-coloured icon instead of the monochrome ones from simpleicons. These ones ignore the logoColor param. You're not the first person to be confused by it. I'm going to close this as a duplicate of #6208 - there's more info in there.
We currently have an issue open at #7684 about dropping the custom icons completely but to the extent anyone has expressed a preference, people seem mostly in favour of keeping the custom ones.

@davidmpaz
Copy link
Author

All good, i just commented on the discussion about my motivations.

Thanks!
David

@chris48s
Copy link
Member

update: #6208 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Support questions, usage questions, unconfirmed bugs, discussions, ideas
Projects
None yet
Development

No branches or pull requests

2 participants