Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix [gitlab] auth #8145

Merged
merged 2 commits into from Jul 1, 2022
Merged

fix [gitlab] auth #8145

merged 2 commits into from Jul 1, 2022

Conversation

calebcartwright
Copy link
Member

Fixes the overwhelming majority, but not totality, of #8143.

I also added a dummy license to our private test repo under the shields-ops-group

@calebcartwright calebcartwright added the service-badge Accepted and actionable changes, features, and bugs label Jul 1, 2022
@shields-ci
Copy link

shields-ci commented Jul 1, 2022

Warnings
⚠️

📚 Remember to ensure any changes to config.private in services/gitlab/gitlab-base.js are reflected in the server secrets documentation

Messages
📖 ✨ Thanks for your contribution to Shields, @calebcartwright!

Generated by 🚫 dangerJS against f0b2c5c

@calebcartwright
Copy link
Member Author

Forgot to explicitly note, but the outstanding piece is the original circumstance that identified this issue. I provided more detail in #8143 (comment) but in short the Contributors badge doesn't utilize auth at all and will need a separate adjustment.

cc @sunny0826 in case you'd like to work on getting the Contributors badge adjusted to utilize the auth

@chris48s
Copy link
Member

chris48s commented Jul 1, 2022

Just to confirm, passing the token in the password field using basic auth just flat-out doesn't work anymore - right?

@calebcartwright
Copy link
Member Author

Just to confirm, passing the token in the password field using basic auth just flat-out doesn't work anymore - right?

Correct. I know I tested this back when I first added it so can only assume it worked at the time, but perhaps that was just legacy behavior GL had been planning on dropping for a while and that finally happened at some point over the last year.

Or perhaps my brain just mistakenly interpreted 404s as 200s 🤷‍♂️

@calebcartwright calebcartwright merged commit 3c6ca5d into master Jul 1, 2022
@calebcartwright calebcartwright deleted the gitlab-bearer-token branch July 1, 2022 21:42
@sunny0826
Copy link
Contributor

Just to confirm, passing the token in the password field using basic auth just flat-out doesn't work anymore - right?

GitLab supports multiple authentication methods, but not user: "", pass: "", which was probably deprecated before I joined GItLab... I even I didn't even find it in the documentation for the old version

@calebcartwright
Copy link
Member Author

To be honest I'm not sure the past really matters all that much at this point unless anyone has an operable time machine and use cases that predate the one surfaced this week.

Whether or not basic auth with a pat only ever worked with git doesn't really make a difference going forward; using the pat in the oauth header does, for now, and that's what we're now using

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service-badge Accepted and actionable changes, features, and bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants