New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix [gitlab] auth #8145
fix [gitlab] auth #8145
Conversation
|
Forgot to explicitly note, but the outstanding piece is the original circumstance that identified this issue. I provided more detail in #8143 (comment) but in short the Contributors badge doesn't utilize auth at all and will need a separate adjustment. cc @sunny0826 in case you'd like to work on getting the Contributors badge adjusted to utilize the auth |
Just to confirm, passing the token in the password field using basic auth just flat-out doesn't work anymore - right? |
Correct. I know I tested this back when I first added it so can only assume it worked at the time, but perhaps that was just legacy behavior GL had been planning on dropping for a while and that finally happened at some point over the last year. Or perhaps my brain just mistakenly interpreted 404s as 200s 🤷♂️ |
GitLab supports multiple authentication methods, but not |
To be honest I'm not sure the past really matters all that much at this point unless anyone has an operable time machine and use cases that predate the one surfaced this week. Whether or not basic auth with a pat only ever worked with git doesn't really make a difference going forward; using the pat in the oauth header does, for now, and that's what we're now using |
Fixes the overwhelming majority, but not totality, of #8143.
I also added a dummy license to our private test repo under the shields-ops-group