Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose port 443 in Dockerfile #8889

Merged
merged 1 commit into from Feb 8, 2023
Merged

expose port 443 in Dockerfile #8889

merged 1 commit into from Feb 8, 2023

Conversation

chris48s
Copy link
Member

@chris48s chris48s commented Feb 7, 2023

If we don't explicitly specify a port, running node server will serve on port 80 if

is false and 443 if it is true, but we don't expose 443 so if that var is true, the port we open in the dockerfile isn't the one the server is listening on.

We could explicitly tell the server to serve TLS on port 80, but I think it makes more sense to expose 443 to cover this case.

This related to #8424
The other thing we need to do on this repo is a PR bumping scoutcamp once we've done a release with badges/sc#6 in it
Then once we've got a docker image with that in it, we're on to PRs in the super secret devops repo 🤫

@chris48s chris48s added the operations Hosting, monitoring, and reliability for the production badge servers label Feb 7, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2023

Messages
📖 ✨ Thanks for your contribution to Shields, @chris48s!

Generated by 🚫 dangerJS against 84da3a3

@chris48s chris48s merged commit 2e627b0 into badges:master Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
operations Hosting, monitoring, and reliability for the production badge servers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants