Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a load of spacing issues in frontend content #9281

Merged
merged 2 commits into from Jun 18, 2023

Conversation

chris48s
Copy link
Member

@chris48s chris48s commented Jun 17, 2023

I'm not going to claim I have caught every single documentation string with a spacing issue, but I reckon I've got >90% of them. This also lays down a pattern for fixing them if we find any more I have missed.

I have mostly chosen to fix these by converting them to markdown (which we can now use instead of HTML, if we want). In one or two cases, I have moved ht HTML around a bit. In general, we might want to consider converting all of these to markdown, but that is a bigger job.

I won't go through every single page with a spacing issue, but here's a few before/after links

before after
https://shields.io/badges/git-hub-contributors-via-allcontributors-org https://pr-9281-badges-shields.fly.dev/badges/git-hub-contributors-via-allcontributors-org
https://shields.io/badges/you-tube-channel-views https://pr-9281-badges-shields.fly.dev/badges/you-tube-channel-views
https://shields.io/badges/ping-pong-status https://pr-9281-badges-shields.fly.dev/badges/ping-pong-status
https://shields.io/badges/git-lab-all-merge-requests https://pr-9281-badges-shields.fly.dev/badges/git-lab-all-merge-requests

Refs #9280

@chris48s chris48s added frontend The React app and the infrastructure that supports it documentation Developer and end-user documentation labels Jun 17, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 17, 2023

Warnings
⚠️ This PR modified service code for amo but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for azure-devops but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for endpoint but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for github but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for gitlab but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for hsts but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for jira but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for mastodon but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for mozilla-observatory but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for nycrc but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for osslifecycle but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for pingpong but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for poeditor but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for pypi but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for security-headers but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for tokei but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for website but not its test code.
That's okay so long as it's refactoring existing code.
Messages
📖 ✨ Thanks for your contribution to Shields, @chris48s!

Generated by 🚫 dangerJS against 5724870

@github-actions
Copy link
Contributor

🚀 Updated review app: https://pr-9281-badges-shields.fly.dev

@github-actions
Copy link
Contributor

🚀 Updated review app: https://pr-9281-badges-shields.fly.dev

@chris48s chris48s changed the title WIP fix a load of spacing issues in frontend fix a load of spacing issues in frontend content Jun 17, 2023
@chris48s
Copy link
Member Author

I'm going to go ahead and just merge this one

@chris48s chris48s merged commit a5f91a4 into badges:master Jun 18, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Developer and end-user documentation frontend The React app and the infrastructure that supports it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant