New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix a load of spacing issues in frontend content #9281
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris48s
added
frontend
The React app and the infrastructure that supports it
documentation
Developer and end-user documentation
labels
Jun 17, 2023
|
🚀 Updated review app: https://pr-9281-badges-shields.fly.dev |
🚀 Updated review app: https://pr-9281-badges-shields.fly.dev |
chris48s
changed the title
WIP fix a load of spacing issues in frontend
fix a load of spacing issues in frontend content
Jun 17, 2023
I'm going to go ahead and just merge this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Developer and end-user documentation
frontend
The React app and the infrastructure that supports it
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not going to claim I have caught every single
documentation
string with a spacing issue, but I reckon I've got >90% of them. This also lays down a pattern for fixing them if we find any more I have missed.I have mostly chosen to fix these by converting them to markdown (which we can now use instead of HTML, if we want). In one or two cases, I have moved ht HTML around a bit. In general, we might want to consider converting all of these to markdown, but that is a bigger job.
I won't go through every single page with a spacing issue, but here's a few before/after links
Refs #9280