fix [bower] version badge #9567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris48s
added
service-badge
calebcartwright
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our bower badges use the libraries.io API. Also bower is a low traffic badge/mostly abandoned service.
The version badge (which should be latest stable version) consistently returns "no releases" for pretty much any package.
This is because if you look at the API response for a bunch of packages e.g:
they all return
latest_stable_release_number: null, although it is worth noting that all of them do have a proper version number againstlatest_release_number, so theinclude_prereleasesvariant works in all those cases.Given the
latest_release_numbernumber doesn't seem to be populated for any package (or at least I can't find an example where it works), I suggest we just switch this so that the version badge returnslatest_release_numberwhether you call it withinclude_prereleasesor not.