Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate [redmine] plugin rating badges #9568

Merged
merged 4 commits into from Sep 17, 2023

Conversation

chris48s
Copy link
Member

Redmine badges have been failing for some time due to a consistent 500 error from the upstream API.

The badge receives little traffic and despite being broken for months, nobody has complained. If we a look at a bunch of different redmine plugins, we see the same thing for all of them:

Suggest we deprecate this service.

@chris48s chris48s added the service-badge Accepted and actionable changes, features, and bugs label Sep 11, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 11, 2023

Messages
📖 ✨ Thanks for your contribution to Shields, @chris48s!

Generated by 🚫 dangerJS against 36d23b4

Copy link
Member

@calebcartwright calebcartwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds reasonable, and changes look good. going to bump the date a tad and then merge

services/redmine/redmine.service.js Outdated Show resolved Hide resolved
services/redmine/redmine.service.js Outdated Show resolved Hide resolved
@chris48s
Copy link
Member Author

The reason this didn't auto-merge is because it was missing an approving review.

@chris48s chris48s merged commit c2bbe97 into badges:master Sep 17, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service-badge Accepted and actionable changes, features, and bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants