fix [GreasyFork] 404 bug

[hymbz]

refs #9611

[github-actions]

	Messages
📖	✨ Thanks for your contribution to Shields, @hymbz!

Generated by 🚫 dangerJS against 7ca212c

[chris48s]

Can you explain the relationship between greasyfork and sleazyfork for someone who doesn't use either?

It is clear they are closely related services, but my instinct is that it would make more sense to add sleazyfork as its own service, rather than treating it as a fallback for greasyfork.

[hymbz]

See https://greasyfork.org/en/forum/discussion/5456/adult-content for reasons. Basically, if a script works on an "adult" sites (even if it's one such site out of a thousand), it cannot be seen on GreasyFork without being logged in.

Sleazyfork is another inlet to Greasyfork, where adult scripts can be displayed without logging in and only adult scripts are visible. Before, this type of script could still retrieve data through the API of Greasyfork, but now it is no longer possible.

[chris48s]

Ok. Thanks for that context. This does seem reasonable.

Two things:

1. Instead of just catching any error, can we explicitly handle NotFound - if there is some other error, there's probably no point making another network call
2. I don't think we need to add one for every single greasyfork badge (downloads, license, rating and version) but can we add at least one service test that follows the sleazyfork path somewhere.

Thanks

[hymbz]

You're right, I have made the necessary changes to the code.

[chris48s]

Could we check for the exception type using instanceof so it will still work if we customise the not found error.

e.g:

import { NotFound } from '../index.js'

...

if (!(e instanceof NotFound)) throw e

[hymbz]

okay

[github-actions]

🚀 Updated review app: https://pr-9632-badges-shields.fly.dev

[chris48s]

nice - thanks