increase page size for [githubrelease] badge by semver #9818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris48s
added
the
service-badge
chris48s
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was something I spotted when I was thinking about the review for #9781
If we are requesting the latest version by semver (rather than date) we request the first page of releases and search it for the latest release. The default page size is 30 releases and the max is 100.
I'm not really sure what happened here. I don't know if GitHub changed the default page size from 100 to 30 at some point or we messed this up in a refactor somewhere, but currently we only search the most recent 30 releases not the most recent 100.
The tags badge already does this correctly
shields/services/github/github-tag.service.js
Lines 87 to 92 in 2814de2