Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix default style docs for social badges #9869

Merged
merged 3 commits into from Jan 4, 2024
Merged

fix default style docs for social badges #9869

merged 3 commits into from Jan 4, 2024

Conversation

chris48s
Copy link
Member

@chris48s chris48s commented Jan 2, 2024

closes #9867

follow up from #9859

@chris48s chris48s added the documentation Developer and end-user documentation label Jan 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 2, 2024 •
edited

Messages
📖 ✨ Thanks for your contribution to Shields, @chris48s!

Generated by 🚫 dangerJS against a11b87c

PyvesB
PyvesB reviewed Jan 3, 2024
View reviewed changes
core/base-service/openapi.js Outdated Show resolved Hide resolved
chris48s and others added 2 commits January 4, 2024 20:03
@chris48s @PyvesB
Update core/base-service/openapi.js
914c894 
Co-authored-by: Pierre-Yves Bigourdan <10694593+PyvesB@users.noreply.github.com>
@chris48s
update test
a11b87c
PyvesB
PyvesB approved these changes Jan 4, 2024
View reviewed changes
Copy link
Member

@PyvesB PyvesB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - obviously a test had to fail, it would have been too easy otherwise!

@chris48s chris48s added this pull request to the merge queue Jan 4, 2024
Merged via the queue into badges:master with commit 26ae5a0 Jan 4, 2024
22 checks passed
@chris48s chris48s deleted the 9867-style-docs branch January 4, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PyvesB PyvesB PyvesB approved these changes

Assignees
No one assigned
Labels
documentation Developer and end-user documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect default style of "GitHub Repo stars" badge
2 participants
@chris48s @PyvesB