Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added custom bucket url support for [Scoop] #9984

Merged
merged 3 commits into from Feb 25, 2024

Conversation

jewlexx
Copy link
Contributor

@jewlexx jewlexx commented Feb 23, 2024

Closes #9982

Copy link
Contributor

github-actions bot commented Feb 23, 2024

Messages
📖 ✨ Thanks for your contribution to Shields, @jewlexx!

Generated by 🚫 dangerJS against e0778d7

@chris48s chris48s added the service-badge Accepted and actionable changes, features, and bugs label Feb 24, 2024
@chris48s
Copy link
Member

Could you add a parameter description to the bucket queryParam explaining that bucket can either be:

Here's an example of what that looks like:

const issuesSearchDocs = `
For a full list of available filters and allowed values,
see GitHub's documentation on
[Searching issues and pull requests](https://docs.github.com/en/search-github/searching-on-github/searching-issues-and-pull-requests)
`

queryParam({
name: 'query',
description: issuesSearchDocs,
example: 'is:closed label:bug author:app/sentry-io',
required: true,
}),

@jewlexx
Copy link
Contributor Author

jewlexx commented Feb 25, 2024

All done, let me know if there are any issues.

Copy link
Contributor

🚀 Updated review app: https://pr-9984-badges-shields.fly.dev

Copy link
Member

@chris48s chris48s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome - thanks 👍
Great first contribution

@chris48s chris48s added this pull request to the merge queue Feb 25, 2024
Merged via the queue into badges:master with commit e87d82f Feb 25, 2024
22 checks passed
@jewlexx jewlexx deleted the custom-scoop-buckets branch February 26, 2024 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service-badge Accepted and actionable changes, features, and bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom bucket URLs for Scoop version shield.
2 participants