Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collection of Dataset without "href" element hangs #15

Closed
ammarshadiq opened this issue Jul 21, 2017 · 3 comments
Closed

Collection of Dataset without "href" element hangs #15

ammarshadiq opened this issue Jul 21, 2017 · 3 comments

Comments

@ammarshadiq
Copy link

Collection of Dataset without "href" element hangs
Reproducing the issue:
Edit the jsonstat file http://json-stat.org/samples/oecd-canada-col.json, remove "href" element in each dataset and parse.

@badosa
Copy link
Owner

badosa commented Jul 21, 2017

We couldn't reproduce the error (by "hangs" I'm assuming you mean the document doesn't validate).

After removing the "href", have you verified the document is still valid JSON?

@badosa badosa closed this as completed Jul 21, 2017
@ammarshadiq
Copy link
Author

ammarshadiq commented Jul 21, 2017

At the bottom of this message are the modified jsonstat file http://json-stat.org/samples/oecd-canada-col.json with the "href" element on dataset class removed. Opening it with http://json-stat.com/explorer/ will produce the following screen, and it doesn't open the dataset.

jsonstat_explorer

`{
"version" : "2.0",
"class" : "collection",
"label" : "OECD-Canada Sample Collection",
"updated" : "2015-12-24",
"link" : {
"item" : [
{
"class" : "dataset",
"label" : "Unemployment rate in the OECD countries 2003-2014",
"note" : [ "Most of the data in this dataset are taken from the individual contributions of national correspondents appointed by the OECD Secretariat with the approval of the authorities of Member countries. Consequently, these data have not necessarily been harmonised at international level." ],
"source" : "Economic Outlook No 92 - December 2012 - OECD Annual Projections",
"updated" : "2012-11-27",
"extension" : {
"contact" : "EcoOutlook@oecd.org",
"metadata" : [
{
"title" : "Economic Outlook Policy and other assumptions underlying the projections Box 1.2 in General assessment",
"href" : "http://www.oecd.org/eco/economicoutlookanalysisandforecasts/EO92macroeconomicsituation.pdf"
},
{
"title" : "Economic Outlook Sources and Methods",
"href" : "http://www.oecd.org/document/22/0,3343,en_2649_34109_33702486_1_1_1_1,00.html"
},
{
"title" : "Database inventory (forthcoming)",
"href" : "http://www.oecd.org/eco/databaseinventory"
},
{
"title" : "OECD Glossary",
"href" : "http://stats.oecd.org/glossary/"
}
]
},
"value" : [5.943826289, 5.39663128, 5.044790587, 4.789362794, 4.379649386, 4.249093453, 5.592226603, 5.230660289, 5.099422942, 5.224336088, 5.50415003, 5.462866231, 4.278559338, 4.939707755, 5.152160612, 4.727182858, 4.399730726, 3.813933625, 4.776912506, 4.391591645, 4.143587245, 4.351345785, 4.695491708, 4.745323313, 8.158333333, 8.4, 8.483333333, 8.266666667, 7.466666667, 7.016666667, 7.891892855, 8.283171959, 7.175138783, 7.381153404, 7.689552898, 7.735442636, 7.594616751, 7.167833951, 6.748691501, 6.307841105, 6.049842626, 6.146014664, 8.284689299, 7.988900419, 7.453609598, 7.32358421, 7.169741525, 6.88122705, 9.5433848, 10.00149582, 9.224422554, 7.773166282, 7.150623348, 7.787221805, 10.80236438, 8.121579077, 7.104778251, 6.477468723, 6.78101031, 6.780198936, 7.818066527, 8.323638425, 7.922330988, 7.142271671, 5.316363283, 4.391669598, 6.675050668, 7.273107122, 6.723482523, 6.936394665, 7.242148075, 7.135151601, 5.344516646, 5.516904324, 4.793715416, 3.868296418, 3.669496447, 3.326692683, 5.821647379, 7.191696186, 7.313112408, 7.544640558, 7.357364231, 7.255659852, 10.03010116, 9.661753538, 7.899232972, 5.905173373, 4.659913473, 5.601684952, 13.87805579, 16.83438817, 12.4576855, 9.873121257, 9.116309666, 8.74566981, 9.017860131, 8.80435787, 8.368797468, 7.702632855, 6.850344695, 6.368216471, 8.269856093, 8.381534292, 7.774845319, 7.722836877, 7.962718148, 7.757742455, 8.503978378, 8.8650811, 8.882978134, 8.835277292, 8.009145174, 7.384897537, 9.129199553, 9.315864403, 9.202432489, 9.877166456, 10.66140443, 10.91985917, 9.134738857, 9.829230121, 10.69442137, 9.694756306, 8.310233377, 7.188163108, 7.429105355, 6.757338631, 5.752587233, 5.28775372, 5.524081118, 5.565600014, 9.712526535, 10.49281197, 9.849833119, 8.890878396, 8.276300402, 7.653084476, 9.460314273, 12.53058153, 17.65238747, 23.5737508, 26.6534591, 27.2364419, 5.860132523, 6.096400087, 7.185491402, 7.451740837, 7.35706148, 7.851089777, 10.0153875, 11.14448405, 10.92071597, 11.12538821, 11.09958634, 10.76358386, 3.352836045, 3.06335905, 2.590345651, 2.878830234, 2.301867378, 2.990597714, 7.241470693, 7.55861225, 7.058807671, 6.138731401, 5.393148124, 5.128315309, 4.739670964, 4.539966682, 4.341850838, 4.415526325, 4.571302023, 6.024123088, 11.81229736, 13.62078809, 14.51224844, 14.79227286, 14.73886731, 14.61076214, 13.28016732, 12.85704871, 11.29834866, 10.47596715, 9.147672881, 7.728344307, 9.476560711, 8.33683595, 7.110513831, 6.8731402, 7.359377644, 6.93094611, 8.444973801, 7.996760207, 7.708360512, 6.777043598, 6.110290905, 6.774113796, 7.800833899, 8.41234985, 8.438703909, 10.55546863, 11.42167502, 11.7584873, 5.25125, 4.717099486, 4.424423923, 4.129376275, 3.84841253, 3.979750388, 5.068375853, 5.058985674, 4.592622773, 4.399496241, 4.355894653, 4.286733019, 3.562065618, 3.67219364, 3.734708533, 3.450431799, 3.233335111, 3.15974989, 3.643064158, 3.715763348, 3.405129308, 3.378067785, 3.618601827, 3.397535556, 3.304883869, 3.710506994, 4.099797561, 4.242014975, 4.182611437, 4.14500326, 5.431987487, 5.778771292, 5.627283477, 6.078760003, 6.589474092, 6.658818611, 2.998805894, 3.695332444, 3.540173119, 3.550553518, 3.672170595, 3.949416134, 5.43621902, 5.373117407, 5.240905522, 5.036393758, 4.990182757, 4.897580596, 3.975713818, 4.894207123, 5.113659881, 4.20994586, 3.475695941, 3.018534226, 3.68444758, 4.383579198, 4.343866431, 5.163411369, 5.801548283, 6.10348765, 4.76074516, 4.018968583, 3.807106599, 3.840522581, 3.655294639, 4.160280272, 6.146341463, 6.537348623, 6.509125435, 6.938443309, 6.568824155, 6.048820957, 4.04172726, 4.186831741, 4.382939676, 3.392420144, 2.498729296, 2.565344859, 3.107969091, 3.521797592, 3.212318473, 3.098584692, 3.098584692, 3.003021166, 19.61702787, 18.97466246, 17.74593227, 13.84039072, 9.601554043, 7.117494731, 8.166610723, 9.622661542, 9.648757987, 10.05073744, 10.49463234, 10.66450371, 6.276549712, 6.666642728, 7.597516675, 7.637987286, 7.99012509, 7.607584033, 9.484363464, 10.81324061, 12.7097409, 15.52457602, 16.93137173, 16.62982306, 17.55389647, 18.22108629, 16.25634386, 13.3725907, 11.14262294, 9.507520125, 12.02516939, 14.37913326, 13.54138898, 13.69591839, 13.5763623, 12.97187212, 6.682102697, 6.291982582, 6.516689478, 5.945157013, 4.816202781, 4.368899066, 5.856004508, 7.240345922, 8.164977774, 8.529917685, 9.708595873, 9.847243093, 11.03816292, 10.54622939, 9.156961086, 8.511101588, 8.264570818, 11.33829871, 18.01195661, 20.06321219, 21.63712759, 25.04773498, 26.89014696, 26.78073067, 6.56574156, 7.373480411, 7.652096974, 7.053667613, 6.127066505, 6.183935584, 8.305635992, 8.372715009, 7.504247076, 7.651519753, 7.912693788, 7.604124855, 4.033356027, 4.31699694, 4.329724566, 3.941659077, 3.57509152, 3.341272685, 4.257833072, 4.44955058, 3.949110999, 3.863659425, 4.109877511, 3.999499419, 10.82310834, 10.58802629, 10.40296232, 10.01247258, 10.06182773, 10.74264555, 13.74762357, 11.65601928, 9.605142332, 9.014001387, 9.320782097, 8.651402638, 5.019884066, 4.768990278, 4.852538715, 5.450636437, 5.355104552, 5.708223236, 7.62507775, 7.861627732, 8.078635307, 8.027613742, 8.275155581, 8.036560522, 5.986539203, 5.523039996, 5.076780521, 4.617465075, 4.619105436, 5.800444743, 9.275245924, 9.627692959, 8.94612643, 8.091574662, 7.810715126, 7.514930043, 8.68886389, 8.942669403, 8.941482912, 8.233837469, 7.409607055, 7.436710115, 9.371745367, 9.891824566, 9.978460373, 11.11907575, 11.9135905, 11.99849464, 6.971079892, 6.859814025, 6.629153129, 6.100565063, 5.656171098, 5.982685271, 8.157564657, 8.320563893, 7.953121271, 7.970392182, 8.15379125, 8.004598637],
"status" : {"10": "e", "11": "e", "22": "e", "23": "e", "34": "e", "35": "e", "46": "e", "47": "e", "58": "e", "59": "e", "70": "e", "71": "e", "82": "e", "83": "e", "94": "e", "95": "e", "106": "e", "107": "e", "118": "e", "119": "e", "130": "e", "131": "e", "142": "e", "143": "e", "154": "e", "155": "e", "166": "e", "167": "e", "178": "e", "179": "e", "190": "e", "191": "e", "202": "e", "203": "e", "214": "e", "215": "e", "226": "e", "227": "e", "238": "e", "239": "e", "250": "e", "251": "e", "262": "e", "263": "e", "274": "e", "275": "e", "286": "e", "287": "e", "298": "e", "299": "e", "310": "e", "311": "e", "322": "e", "323": "e", "334": "e", "335": "e", "346": "e", "347": "e", "358": "e", "359": "e", "370": "e", "371": "e", "382": "e", "383": "e", "394": "e", "395": "e", "406": "e", "407": "e", "418": "e", "419": "e", "430": "e", "431": "e"},
"id" : ["concept", "area", "year"],
"size" : [1, 36, 12],
"role" :{
"time" : ["year"],
"geo" : ["area"],
"metric" : ["concept"]
},
"dimension" : {
"concept" : {
"label" : "indicator",
"extension" : {
"definition" : {
"UNR" : "The OECD harmonised unemployment rate gives the number of unemployed persons as a percentage of the labour force (the total number of people employed plus unemployed)."
}
},
"category" : {
"label" : {
"UNR" : "unemployment rate"
},
"unit" : {
"UNR" : {
"symbol" : "%",
"decimals" : 9
}
}
}
},

				"year" : {
					"label" : "2003-2014",
					"category" : {
						"index" : {
							"2003" : 0,
							"2004" : 1,
							"2005" : 2,
							"2006" : 3,
							"2007" : 4,
							"2008" : 5,
							"2009" : 6,
							"2010" : 7,
							"2011" : 8,
							"2012" : 9,
							"2013" : 10,
							"2014" : 11
						}
					}
				},

				"area" : {
					"label" : "OECD countries, EU15 and total",
					"note" : [ "Except where otherwise indicated, data refer to the actual territory of the country considered." ],
					"category" : {
						"index" : {
							"AU" : 0,
							"AT" : 1,
							"BE" : 2,
							"CA" : 3,
							"CL" : 4,
							"CZ" : 5,
							"DK" : 6,
							"EE" : 7,
							"FI" : 8,
							"FR" : 9,
							"DE" : 10,
							"GR" : 11,
							"HU" : 12,
							"IS" : 13,
							"IE" : 14,
							"IL" : 15,
							"IT" : 16,
							"JP" : 17,
							"KR" : 18,
							"LU" : 19,
							"MX" : 20,
							"NL" : 21,
							"NZ" : 22,
							"NO" : 23,
							"PL" : 24,
							"PT" : 25,
							"SK" : 26,
							"SI" : 27,
							"ES" : 28,
							"SE" : 29,
							"CH" : 30,
							"TR" : 31,
							"UK" : 32,
							"US" : 33,
							"EU15" : 34,
							"OECD" : 35
						},
						"label" : {
							"AU" : "Australia",
							"AT" : "Austria",
							"BE" : "Belgium",
							"CA" : "Canada",
							"CL" : "Chile",
							"CZ" : "Czech Republic",
							"DK" : "Denmark",
							"EE" : "Estonia",
							"FI" : "Finland",
							"FR" : "France",
							"DE" : "Germany",
							"GR" : "Greece",
							"HU" : "Hungary",
							"IS" : "Iceland",
							"IE" : "Ireland",
							"IL" : "Israel",
							"IT" : "Italy",
							"JP" : "Japan",
							"KR" : "Korea",
							"LU" : "Luxembourg",
							"MX" : "Mexico",
							"NL" : "Netherlands",
							"NZ" : "New Zealand",
							"NO" : "Norway",
							"PL" : "Poland",
							"PT" : "Portugal",
							"SK" : "Slovak Republic",
							"SI" : "Slovenia",
							"ES" : "Spain",
							"SE" : "Sweden",
							"CH" : "Switzerland",
							"TR" : "Turkey",
							"UK" : "United Kingdom",
							"US" : "United States",
							"EU15" : "Euro area (15 countries)",
							"OECD" : "total"
						},
						"note" : {
							"DE" : [ "Germany (code DE) was created 3 October 1990 by the accession of the Democratic Republic of Germany (code DDR) to the then Federal Republic of Germany (code DEW)." ]
						},
						"child" : {
							"EU15" : ["AT", "BE", "DE", "DK", "ES", "FI", "FR", "GR", "IE", "IT", "LU", "NL", "PT", "SE", "UK"],
							"OECD" : [ "EU15", "AU", "CA", "CL", "CZ", "DK", "EE", "HU", "IS", "IL", "JP", "KR", "MX", "NO", "NZ", "PL", "SK", "SI", "CH", "TR", "US"]
						}
					}
				}
			}
		},
		{
			"class" : "dataset",
			"label" : "Population by sex and age group. Canada. 2012",
			"source" : "Statistics Canada, CANSIM, table 051-0001",
			"updated" : "2012-09-27",
			"value" : [34880.5, 17309.1, 17571.3, 100.0, 100.0, 100.0, 1928.8, 988.7, 940.1, 5.5, 5.7, 5.3, 1857.1, 955.0, 902.1, 5.3, 5.5, 5.1, 1877.3, 964.7, 912.6, 5.4, 5.6, 5.2, 2163.0, 1108.2, 1054.7, 6.2, 6.4, 6.0, 2441.1, 1254.2, 1186.9, 7.0, 7.2, 6.8, 2452.3, 1246.8, 1205.5, 7.0, 7.2, 6.9, 2406.3, 1203.5, 1202.8, 6.9, 7.0, 6.8, 2307.2, 1155.2, 1152.0, 6.6, 6.7, 6.6, 2384.6, 1199.4, 1185.2, 6.8, 6.9, 6.7, 2681.3, 1350.1, 1331.2, 7.7, 7.8, 7.6, 2703.2, 1352.3, 1350.9, 7.7, 7.8, 7.7, 2428.5, 1199.0, 1229.5, 7.0, 6.9, 7.0, 2063.0, 1010.2, 1052.8, 5.9, 5.8, 6.0, 1645.1, 797.9, 847.2, 4.7, 4.6, 4.8, 1190.7, 563.8, 626.8, 3.4, 3.3, 3.6, 924.1, 418.9, 505.2, 2.6, 2.4, 2.9, 718.8, 303.6, 415.2, 2.1, 1.8, 2.4, 451.0, 164.1, 286.9, 1.3, 0.9, 1.6, 257.1, 73.2, 183.9, 0.7, 0.4, 1.0],
			"status" : ["a"],
			"id" : ["country", "year", "age", "concept", "sex"],
			"size" : [1, 1, 20, 2, 3],
			"role" :{
				"time" : ["year"],
				"geo" : ["country"],
				"metric" : ["concept"]
			},
			"dimension" : {
				"concept" : {
					"label" : "concepts",
					"category" : {
						"index" : {
							"POP" : 0,
							"PERCENT" : 1
						},
						"label" : {
							"POP" : "population",
							"PERCENT" : "weight of age group in the population"
						},
						"unit" : {
							"POP" : {
								"label": "thousands of persons",
								"decimals": 1
							},
							"PERCENT" : {
								"symbol" : "%",
								"decimals": 1
							}
						}
					}
				},

				"year" : {
					"label" : "year",
					"category" : {
						"index" : {
							"2012" : 0
						}
					}
				},

				"country" : {
					"label" : "country",
					"category" : {
						"label" : {
							"CA" : "Canada"
						}
					}
				},

				"age" : {
					"label" : "age group",
					"category" : {
						"index" : [
							"T",
							"4",
							"9",
							"14",
							"19",
							"24",
							"29",
							"34",
							"39",
							"44",
							"49",
							"54",
							"59",
							"64",
							"69",
							"74",
							"79",
							"84",
							"89",
							"older"
						],
						"label" : {
							"T": "total",
							"4": "0 to 4",
							"9": "5 to 9",
							"14": "10 to 14",
							"19": "15 to 19",
							"24": "20 to 24",
							"29": "25 to 29",
							"34": "30 to 34",
							"39": "35 to 39",
							"44": "40 to 44",
							"49": "45 to 49",
							"54": "50 to 54",
							"59": "55 to 59",
							"64": "60 to 64",
							"69": "65 to 69",
							"74": "70 to 74",
							"79": "75 to 79",
							"84": "80 to 84",
							"89": "85 to 89",
							"older": "90 and older"
						}
					}
				},

				"sex" : {
					"label" : "sex",

					"link" : {
						"alternate" : [
							{
								"type" : "text/html",
								"href" : "http://www.statcan.gc.ca/concepts/definitions/class-sex-eng.htm"
							}
						]
					},
					"category" : {
						"index" : ["T", "M", "F"],
						"label" : {
							"T" : "total",
							"M" : "male",
							"F" : "female"
						}
					}
				}
			}
		}
	]
}

}`

@badosa
Copy link
Owner

badosa commented Jul 22, 2017

Ah ok, now I understand. This is not an issue of the format or the validator, just a limitation of the JSON-stat Explorer, which can be considered a demo.

It's true: the Explorer assumes the more common case that collections don't have embedded content, or if they have it is also available by reference (href).

If I have the time I'll try to improve this aspect of the Explorer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants