Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with comments #24

Closed
WilliamVercken opened this issue Oct 23, 2013 · 9 comments
Closed

Issue with comments #24

WilliamVercken opened this issue Oct 23, 2013 · 9 comments

Comments

@WilliamVercken
Copy link

Hi !

Sorry, I found another issue. :)

/*
// Lorem ipsum Nisi aute velit quis.
.lorem{ipsum:none;}
*/

When I use SassBeautify, the first /* becomes //

//
// Lorem ipsum Nisi aute velit quis.
.lorem{ipsum:none;}
*/

I can't comment code that has inline comments...
That's all ! :)

Thanks a lot,
William

@badsyntax
Copy link
Owner

Looks like you've found another bug with sass. I'll create a ticket on the sass repo.

@badsyntax
Copy link
Owner

See: sass/sass#986

@WilliamVercken
Copy link
Author

Great, thank you ! :) 👍

@badsyntax
Copy link
Owner

This was fixed in sass master with commit sass/sass@e92c472

I'll update this ticket when the sass version that contains this fix is released.

@badsyntax
Copy link
Owner

Looks like this fix is merged into stable for the 3.3.0 release. It's also mentioned in the changelog: http://sass-lang.com/documentation/file.SASS_CHANGELOG.html

When you've got a chance can you test this with Sass 3.3.0 and close the ticket if it works?

@WilliamVercken
Copy link
Author

Hi ! Good news. :)
I have to wait my tools to be updated before passing to 3.3.0.
I'll tell you when I'll be able to test it !

@badsyntax
Copy link
Owner

I've just tested with the latest stable (3.3.3) and this issue no longer exists. Closing...

@WilliamVercken
Copy link
Author

Great ! Sorry, I didn't had a chance to test it myself...

@badsyntax
Copy link
Owner

No problemo! Thanks for reporting the issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants